Make touch event support a RuntimeEnabledFeature

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Garret Kelly]

In anticipation of being able to disable and enable this feature under certain platforms at runtime.

[Garret Kelly]

Created attachment 53220 [details]
Initial patch

[WebKit Review Bot]

Attachment 53220 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1669314

[Darin Fisher (:fishd, Google)]

Comment on attachment 53220 [details]
Initial patch

Why is the default state enabled and not disabled?  It looks like the qt/gtk bots are not happy.

[Garret Kelly]

The default state is enabled to keep the Chromium build bots happy (but will be changed to disabled in a future patch that adds the enable to DRT for Chromium). The feature's not even enabled on Gtk, but both bots are failing because their include paths don't have WebCore/bindings/generic in them.

[Eric Seidel (no email)]

Comment on attachment 53220 [details]
Initial patch

OK.  Looks like this might break Qt/Gtk though so cq-

[Garret Kelly]

Created attachment 54059 [details]
Fix build issues in initial patch

[Garret Kelly]

Created attachment 54075 [details]
Qt Fix

[Adam Barth]

Comment on attachment 54075 [details]
Qt Fix

Please make sure this works on Qt before landing.

[Csaba Osztrogonác]

I tested the patch manually, but unfortunately I got a link-time error:

obj/debug/Document.o: In function `WebCore::RuntimeEnabledFeatures::touchEnabled()':
../WebCore/bindings/generic/RuntimeEnabledFeatures.h:98: undefined reference to `WebCore::RuntimeEnabledFeatures::isTouchEnabled'
collect2: ld returned 1 exit status
make[1]: *** [../lib/libQtWebKit.so.4.6.0] Error 1

The root of the problem is that the initialization of RuntimeEnabledFeatures::isTouchEnabled (static member) can be found in WebCore/bindings/generic/RuntimeEnabledFeatures.cpp, but this file isn't builded for Qt port.

Adding RuntimeEnabledFeatures.cpp wouldn't solve the problem, because of the following error:
../../../WebCore/bindings/generic/RuntimeEnabledFeatures.cpp: In static member function 'static bool WebCore::RuntimeEnabledFeatures::webSocketEnabled()':
../../../WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:90: error: 'isAvailable' is not a member of 'WebCore::WebSocket'

WebSocket::isAvailable() is implemented in WebCore/websockets/WebSocket.cpp guarded by #if USE(V8).

[Csaba Osztrogonác]

Comment on attachment 54075 [details]
Qt Fix

r- -ed because this patch would brake Qt build. See my comment #9.

[Garret Kelly]

Created attachment 54416 [details]
Remove platform entaglement

[WebKit Commit Bot]

Comment on attachment 54416 [details]
Remove platform entaglement

Clearing flags on attachment: 54416

Committed r58363: <http://trac.webkit.org/changeset/58363>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.