Bug 37472

Summary: Add stub files for running new-run-webkit-tools for the Qt port
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: Tools / TestsAssignee: Tor Arne Vestbø <vestbo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
stub
none
stub + newline
none
stub + newline + style fixes none

Tor Arne Vestbø
Reported 2010-04-12 16:14:20 PDT
Still needs work
Attachments
stub (9.96 KB, patch)
2010-04-12 16:15 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
stub + newline (9.94 KB, patch)
2010-04-12 16:27 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
stub + newline + style fixes (9.94 KB, patch)
2010-04-12 16:36 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-04-12 16:15:11 PDT
Created attachment 53189 [details] stub
WebKit Review Bot
Comment 2 2010-04-12 16:20:27 PDT
Attachment 53189 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/Scripts/webkitpy/layout_tests/port/qt.py:121: no newline at end of file [pep8/W292] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tor Arne Vestbø
Comment 3 2010-04-12 16:27:39 PDT
Created attachment 53192 [details] stub + newline
WebKit Review Bot
Comment 4 2010-04-12 16:32:09 PDT
Attachment 53192 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/Scripts/webkitpy/layout_tests/port/qt.py:121: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tor Arne Vestbø
Comment 5 2010-04-12 16:36:24 PDT
Created attachment 53196 [details] stub + newline + style fixes
Eric Seidel (no email)
Comment 6 2010-04-12 16:59:22 PDT
Comment on attachment 53196 [details] stub + newline + style fixes It's a good start. Thanks!
WebKit Commit Bot
Comment 7 2010-04-12 18:00:03 PDT
Comment on attachment 53196 [details] stub + newline + style fixes Clearing flags on attachment: 53196 Committed r57491: <http://trac.webkit.org/changeset/57491>
WebKit Commit Bot
Comment 8 2010-04-12 18:00:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.