| Summary: | Auto-generate V8 bindings for Canvas.* overloads | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yaar Schnitman <yaar> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, eric, ggaren, gustavo, japhet, sam, webkit-ews, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Bug Depends on: | 37373 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Yaar Schnitman
2010-04-12 10:53:32 PDT
Created attachment 53178 [details]
Patch
Attachment 53178 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1586398 Attachment 53178 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1669299 Attachment 53178 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1692152 Attachment 53178 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1610428 Created attachment 53490 [details]
Patch
Attachment 53490 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/test/V8TestObj.cpp:308: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 53490 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1651436 Attachment 53490 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1650421 Attachment 53490 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1686275 Created attachment 53537 [details]
Patch
Comment on attachment 53537 [details]
Patch
Its working! Please cq+ if ok.
Attachment 53537 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/test/V8TestObj.cpp:308: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
WebCore/bindings/v8/test/V8TestObj.cpp:436: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 53537 [details]
Patch
Woah! This change is awesome.
Comment on attachment 53537 [details] Patch Clearing flags on attachment: 53537 Committed r57787: <http://trac.webkit.org/changeset/57787> All reviewed patches have been landed. Closing bug. OMG. How does JSC get this too? :) (In reply to comment #17) > OMG. How does JSC get this too? :) I'm still ironing out the quirks of the V8 overloads generation by testing it on more use cases (e.g. WebGL). Once done, I'll implement also in JSC. |