Summary: | Remove use of STL data structures from CoreIPC code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Sam Weinig
2010-04-10 19:52:07 PDT
Created attachment 53066 [details]
Patch
Please ignore the NotImplemented.h bits. That should not be there. Created attachment 53074 [details]
Updated patch
This updates the patch to use a Vector instead of a Deque in Connection as per Anders' request. It also changes some uses of malloc/free with fastMalloc/fastFree.
Comment on attachment 53074 [details] Updated patch > - queue<WorkItem*> workItemQueue; > + Deque<WorkItem*> workItemQueue; You said this updates the patch to use a Vector instead of a Deque. But this is a Deque. (In reply to comment #4) > (From update of attachment 53074 [details]) > > - queue<WorkItem*> workItemQueue; > > + Deque<WorkItem*> workItemQueue; > > You said this updates the patch to use a Vector instead of a Deque. But this is > a Deque. Only in Connection for the incomming/outgoing message queues. Comment on attachment 53074 [details] Updated patch > Index: WebKit2/Platform/RunLoop.h > =================================================================== > --- WebKit2/Platform/RunLoop.h (revision 57421) > +++ WebKit2/Platform/RunLoop.h (working copy) > @@ -27,7 +27,7 @@ > #define RunLoop_h > > #include <memory> > -#include <queue> > +#include <wtf/Deque.h> > #include <wtf/HashMap.h> > #include <wtf/Threading.h> > > @@ -99,7 +99,7 @@ private: > void wakeUp(); > > Mutex m_workItemQueueLock; > - std::queue<WorkItem*> m_workItemQueue; > + Deque<WorkItem*> m_workItemQueue; This can actually be a Vector. Created attachment 53099 [details]
Take 3
Comment on attachment 53099 [details]
Take 3
Great, r=me!
|