Summary: | Expose UserContentURLPattern as WebKit SPI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | timothy, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-04-09 13:31:32 PDT
Created attachment 53475 [details]
Expose UserContentURLPattern as WebKit SPI
Attachment 53475 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 53475 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not > be indented. [whitespace/indent] [4] This is bug 36760. > WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header > this file implements. Should be: config.h, primary header, blank line, and then > alphabetically sorted. [build/include_order] [4] > WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements > after other header. Should be: config.h, primary header, blank line, and then > alphabetically sorted. [build/include_order] [4] This is bug 37673. Comment on attachment 53475 [details]
Expose UserContentURLPattern as WebKit SPI
Looks fine. But isValid() needs to be exposed.
Created attachment 53479 [details]
Revised patch with isValid
Attachment 53479 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r57680: <http://trac.webkit.org/changeset/57680> |