Bug 37354

Summary: Expose UserContentURLPattern as WebKit SPI
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Expose UserContentURLPattern as WebKit SPI
none
Revised patch with isValid timothy: review+

Adam Roben (:aroben)
Reported 2010-04-09 13:31:32 PDT
We'd like to expose UserContentURLPattern as WebKit SPI.
Attachments
Expose UserContentURLPattern as WebKit SPI (25.89 KB, patch)
2010-04-15 14:09 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Revised patch with isValid (26.59 KB, patch)
2010-04-15 14:37 PDT, Adam Roben (:aroben) 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-04-09 13:32:15 PDT
<rdar://problem/7847210>
Adam Roben (:aroben)
Comment 2 2010-04-15 14:09:12 PDT
Created attachment 53475 [details] Expose UserContentURLPattern as WebKit SPI
WebKit Review Bot
Comment 3 2010-04-15 14:12:52 PDT
Attachment 53475 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 4 2010-04-15 14:18:36 PDT
(In reply to comment #3) > Attachment 53475 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not > be indented. [whitespace/indent] [4] This is bug 36760. > WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header > this file implements. Should be: config.h, primary header, blank line, and then > alphabetically sorted. [build/include_order] [4] > WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements > after other header. Should be: config.h, primary header, blank line, and then > alphabetically sorted. [build/include_order] [4] This is bug 37673.
Timothy Hatcher
Comment 5 2010-04-15 14:25:41 PDT
Comment on attachment 53475 [details] Expose UserContentURLPattern as WebKit SPI Looks fine. But isValid() needs to be exposed.
Adam Roben (:aroben)
Comment 6 2010-04-15 14:37:34 PDT
Created attachment 53479 [details] Revised patch with isValid
WebKit Review Bot
Comment 7 2010-04-15 14:41:02 PDT
Attachment 53479 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 8 2010-04-15 15:20:48 PDT
Committed r57680: <http://trac.webkit.org/changeset/57680>
Note You need to log in before you can comment on or make changes to this bug.