Bug 37337
| Summary: | [GTK] :visited tests added in r57292 fail on GTK because LayoutTestController::computedStyleIncludingVisitedInfo is unimplemented | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | zan |
| Priority: | P2 | Keywords: | LayoutTestFailure, PlatformOnly |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
Adam Roben (:aroben)
The following three tests fail on GTK because LayoutTestController::computedStyleIncludingVisitedInfo is unimplemented:
fast/history/nested-visited-test.html
fast/history/self-is-visited.html
fast/history/sibling-visited-test.html
Platform-specific failing results have been checked in for them. But we should implement this LayoutTestController API so we can pass them!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zan Dobersek
The function is now implemented and all three tests passing.
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp#L110
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fhistory%2Fnested-visited-test.html%2Cfast%2Fhistory%2Fself-is-visited.html%2Cfast%2Fhistory%2Fsibling-visited-test.html