Summary: | Crash exiting fullscreen with captions enabled | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Critical | CC: | commit-queue, darin, eric, jer.noble, simon.fraser | ||||||||||
Priority: | P1 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac (Intel) | ||||||||||||
OS: | OS X 10.6 | ||||||||||||
Attachments: |
|
Description
Jer Noble
2010-04-09 00:35:13 PDT
Created attachment 52957 [details]
Patch
Comment on attachment 52957 [details] Patch Rejecting patch 52957 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: /bin/sh -c /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebKit.build/Debug/WebKit.build/Script-5DE6D18C0FCF231B002DE28C.sh ** BUILD FAILED ** The following build commands failed: WebKit: Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/i386/WebVideoFullscreenController.o /Users/eseidel/Projects/CommitQueue/WebKit/mac/WebView/WebVideoFullscreenController.mm normal i386 objective-c++ com.apple.compilers.gcc.4_2 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/1669224 Created attachment 52960 [details]
Patch
Comment on attachment 52960 [details] Patch Clearing flags on attachment: 52960 Committed r57343: <http://trac.webkit.org/changeset/57343> All reviewed patches have been landed. Closing bug. I believe this broke Tiger: /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/WebKit/mac/WebView/WebVideoFullscreenController.mm: In function 'void -[WebVideoFullscreenController windowDidLoad](WebVideoFullscreenController*, objc_selector*)': /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/WebKit/mac/WebView/WebVideoFullscreenController.mm:89: error: 'QTMovieLayer' was not declared in this scope /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/WebKit/mac/WebView/WebVideoFullscreenController.mm:89: error: 'layer' was not declared in this scope cc1objplus: warnings being treated as errors We have code to make the commit-queue auto-rollout when it lands patches which break things. Its intentionally disabled for now. Reverted r57343 for reason: Broke Tiger compile. Committed r57348: <http://trac.webkit.org/changeset/57348> Created attachment 52992 [details]
Patch
Comment on attachment 52992 [details] Patch > -SOFT_LINK_CLASS(QTKit, QTMovieView) > +SOFT_LINK_CLASS(QTKit, QTMovieLayer) Does this need to go inside the ifdef? > +#ifdef BUILDING_ON_TIGER > + // WebVideoFullscreenController is not supported on Tiger: > + ASSERT_NOT_REACHED(); I think it would be even better to put the entire body of the function inside the #ifdef. Comment on attachment 52992 [details]
Patch
I didn't set commit-queue+ but some other reviewer could after getting the answer from Jer.
> Does this need to go inside the ifdef?
No, that macro expands into a set of ObjC functions which obtain a Class pointer at runtime. There will be no compile-time references to QTMovieLayer, except in string form. (i.e. "QTMovieLayer")
I'll also include the entire body of the two functions in the #ifdef and resubmit the patch.
Created attachment 53011 [details]
Patch
Comment on attachment 53011 [details] Patch Clearing flags on attachment: 53011 Committed r57403: <http://trac.webkit.org/changeset/57403> All reviewed patches have been landed. Closing bug. |