Bug 37271

Summary:

[chromium] Expose SecurityOrigin::canRequest in WebSecurityOrigin.

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

jochen

Reported 2010-04-08 07:43:46 PDT

Expose SecurityOrigin::canRequest in WebSecurityOrigin.

Attachments
Patch (2.35 KB, patch) 2010-04-08 07:44 PDT, jochen	no flags	Details Formatted Diff Diff
Patch (2.41 KB, patch) 2010-04-08 23:35 PDT, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2010-04-08 07:44:53 PDT

Created attachment 52864 [details] Patch

Adam Barth

Comment 2 2010-04-08 09:02:57 PDT

LGTM, but you need fishd's review for WebKit API changes.

Darin Fisher (:fishd, Google)

Comment 3 2010-04-08 11:00:34 PDT

Comment on attachment 52864 [details] Patch > + // Returns true if this WebSecurityOrigin can read content retrieved from > + // the given URL. For example, call this function before issuing > + // XMLHttpRequests. > + WEBKIT_API bool canRequest(const WebURL&) const; nit: The XMLHttpRequest example doesn't really apply to WebKit API consumers. Otherwise, this change is fine. Please post a revised patch for the commit queue.

jochen

Comment 4 2010-04-08 23:35:31 PDT

Created attachment 52938 [details] Patch

Adam Barth

Comment 5 2010-04-08 23:37:26 PDT

Comment on attachment 52938 [details] Patch Picture perfect

WebKit Commit Bot

Comment 6 2010-04-09 03:46:26 PDT

Comment on attachment 52938 [details] Patch Clearing flags on attachment: 52938 Committed r57325: <http://trac.webkit.org/changeset/57325>

WebKit Commit Bot

Comment 7 2010-04-09 03:46:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.