Bug 37271

Summary: [chromium] Expose SecurityOrigin::canRequest in WebSecurityOrigin.
Product: WebKit Reporter: jochen
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description jochen 2010-04-08 07:43:46 PDT
Expose SecurityOrigin::canRequest in WebSecurityOrigin.
Comment 1 jochen 2010-04-08 07:44:53 PDT
Created attachment 52864 [details]
Patch
Comment 2 Adam Barth 2010-04-08 09:02:57 PDT
LGTM, but you need fishd's review for WebKit API changes.
Comment 3 Darin Fisher (:fishd, Google) 2010-04-08 11:00:34 PDT
Comment on attachment 52864 [details]
Patch

> +    // Returns true if this WebSecurityOrigin can read content retrieved from
> +    // the given URL. For example, call this function before issuing
> +    // XMLHttpRequests.
> +    WEBKIT_API bool canRequest(const WebURL&) const;

nit: The XMLHttpRequest example doesn't really apply to WebKit API consumers.

Otherwise, this change is fine.  Please post a revised patch for the commit queue.
Comment 4 jochen 2010-04-08 23:35:31 PDT
Created attachment 52938 [details]
Patch
Comment 5 Adam Barth 2010-04-08 23:37:26 PDT
Comment on attachment 52938 [details]
Patch

Picture perfect
Comment 6 WebKit Commit Bot 2010-04-09 03:46:26 PDT
Comment on attachment 52938 [details]
Patch

Clearing flags on attachment: 52938

Committed r57325: <http://trac.webkit.org/changeset/57325>
Comment 7 WebKit Commit Bot 2010-04-09 03:46:32 PDT
All reviewed patches have been landed.  Closing bug.