Bug 37267 – Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 52860 [details]
[IMAGE] Screenshot while running with patch.

[Pavel Feldman]

Created attachment 52861 [details]
[PATCH] Proposed change.

[Yury Semikhatsky]

Comment on attachment 52861 [details]
[PATCH] Proposed change.

>      if (m_mainResource) {
>          m_mainResource->markDOMContentEventTime();
> +        if (m_timelineAgent)
> +            m_timelineAgent->didMarkDOMContentEvent();
Be consistent in naming methods. It should be markDOMContentEventTime, no "did" prefix when there is no corresponding request.


>      if (m_mainResource) {
>          m_mainResource->markLoadEventTime();
> +        if (m_timelineAgent)
> +            m_timelineAgent->didMarkLoadEvent();
Ditto.

[Pavel Feldman]

Created attachment 52869 [details]
[IMAGE] Screenshot while running with patch. (Updated).

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 52861 [details])
> >      if (m_mainResource) {
> >          m_mainResource->markDOMContentEventTime();
> > +        if (m_timelineAgent)
> > +            m_timelineAgent->didMarkDOMContentEvent();
> Be consistent in naming methods. It should be markDOMContentEventTime, no "did"
> prefix when there is no corresponding request.
> 

Am happy to do in a separate change (there is a bunch of items like this).

> 
> >      if (m_mainResource) {
> >          m_mainResource->markLoadEventTime();
> > +        if (m_timelineAgent)
> > +            m_timelineAgent->didMarkLoadEvent();
> Ditto.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/timeline-enum-stability-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/TimelineAgent.js
	M	WebCore/inspector/front-end/TimelineGrid.js
	M	WebCore/inspector/front-end/TimelineOverviewPane.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r57280

[Timothy Hatcher]

I wonder if we should have the same look in Resources?

[Brian Weinstein]

Are there tooltips to show what these lines mean? The resources panel had tooltips to say that these were for DOM Content Loaded and the Load event.

[Pavel Feldman]

(In reply to comment #7)
> I wonder if we should have the same look in Resources?

You mean short dividers? They were cluttering timeline a lot, but timeline is more dense than resources. So I don't have strong opinion.

(In reply to comment #8)
> Are there tooltips to show what these lines mean? The resources panel had
> tooltips to say that these were for DOM Content Loaded and the Load event.

Yes, same styles / code patterns are used across timeline and resources.