Bug 37234

Summary: [V8] Fix crash in NodeFilterCondition in detached iframe
Product: WebKit Reporter: Vitaly Repeshko <vitalyr>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch v1
vitalyr: review-
patch v2 dglazkov: review+

Description Vitaly Repeshko 2010-04-07 15:06:56 PDT
[V8] Fix crash in NodeFilterCondition in detached document
Comment 1 Vitaly Repeshko 2010-04-07 15:34:09 PDT
Created attachment 52791 [details]
patch v1
Comment 2 Vitaly Repeshko 2010-04-07 15:39:41 PDT
Created attachment 52792 [details]
patch v2
Comment 3 Dimitri Glazkov (Google) 2010-04-07 21:04:23 PDT
Comment on attachment 52792 [details]
patch v2

can we use this func in other places too?
Comment 4 Vitaly Repeshko 2010-04-08 03:16:48 PDT
(In reply to comment #3)
> (From update of attachment 52792 [details])
> can we use this func in other places too?

Yes, it actually should also be used in xpath ns resolver. I updated it as well.
Comment 5 Vitaly Repeshko 2010-04-08 03:17:09 PDT
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/dom/node-filter-detached-iframe-crash-expected.txt
	A	LayoutTests/fast/dom/node-filter-detached-iframe-crash.html
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8DOMWrapper.h
	M	WebCore/bindings/v8/V8NodeFilterCondition.cpp
	M	WebCore/bindings/v8/V8Proxy.cpp
	M	WebCore/bindings/v8/V8Proxy.h
	M	WebCore/bindings/v8/custom/V8CustomXPathNSResolver.cpp
	M	WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h
	M	WebCore/bindings/v8/custom/V8DocumentCustom.cpp
Committed r57269