Bug 37192

Summary:

Web Inspector: test expectations for chromium were changed.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

commit-queue, eric, jaimeyap, pfeldman, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[patch] Fixed version of expectations.	yurys: review+, commit-queue: commit-queue-
[patch] now with fixed style.	none

Ilya Tikhonovsky

Reported 2010-04-07 01:36:48 PDT

Now it is possible to use callerFunctionName for the events initiated by JS code. Will support that in the inspector front-end soon.

Attachments
[patch] Fixed version of expectations. (3.70 KB, patch) 2010-04-07 01:42 PDT, Ilya Tikhonovsky	yurys: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
[patch] now with fixed style. (3.71 KB, patch) 2010-04-07 02:23 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2010-04-07 01:42:47 PDT

Created attachment 52712 [details] [patch] Fixed version of expectations.

WebKit Commit Bot

Comment 2 2010-04-07 02:16:59 PDT

Comment on attachment 52712 [details] [patch] Fixed version of expectations. Rejecting patch 52712 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: /inspector/timeline-parse-html-expected.txt A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/1658218

Ilya Tikhonovsky

Comment 3 2010-04-07 02:23:39 PDT

Created attachment 52718 [details] [patch] now with fixed style.

jaimeyap

Comment 4 2010-04-07 12:56:18 PDT

I have rolled these layout test fixes in to https://bugs.webkit.org/show_bug.cgi?id=36839. I think we can mark this issue now as a Dupe.

Eric Seidel (no email)

Comment 5 2010-04-07 14:00:38 PDT

I'm confused if this patch should be committed or not?

jaimeyap

Comment 6 2010-04-07 14:14:17 PDT

No dont commit this. It was rolled in to https://bugs.webkit.org/show_bug.cgi?id=36839 (should have been there to begin with).

Eric Seidel (no email)

Comment 7 2010-04-07 14:30:43 PDT

*** This bug has been marked as a duplicate of bug 36839 ***

Note You need to log in before you can comment on or make changes to this bug.