Bug 37180

Summary: Checking in new baselines for Chromium media tests.
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
2010-04-06 Andrew Scherkus <scherkus@chromium.org> none

Andrew Scherkus
Reported 2010-04-06 16:47:40 PDT
media/video-controls-rendering.html needed a new baseline when Linux scrollbars changed. fast/layers/video-layer.html was for whatever reason completely ignored and is actually passing!
Attachments
2010-04-06 Andrew Scherkus <scherkus@chromium.org> (205.78 KB, patch)
2010-04-06 16:48 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2010-04-06 16:48:50 PDT
Created attachment 52683 [details] 2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Eric Seidel (no email)
Comment 2 2010-04-06 18:58:35 PDT
Comment on attachment 52683 [details] 2010-04-06 Andrew Scherkus <scherkus@chromium.org> I don't think these types of changes need review. I guess you're not a committer yet though, so you still need to post the patch to use the cq, that must be it. :)
WebKit Commit Bot
Comment 3 2010-04-06 21:18:09 PDT
Comment on attachment 52683 [details] 2010-04-06 Andrew Scherkus <scherkus@chromium.org> Clearing flags on attachment: 52683 Committed r57191: <http://trac.webkit.org/changeset/57191>
WebKit Commit Bot
Comment 4 2010-04-06 21:18:13 PDT
All reviewed patches have been landed. Closing bug.
Andrew Scherkus
Comment 5 2010-04-06 22:46:20 PDT
Nah I'm a committer... just not completely comfortable checking in unreviewed layout test baselines at times :) Thanks for the cq+!
Note You need to log in before you can comment on or make changes to this bug.