Summary: | [Qt] Fix trunk (non-standalone) builds for Symbian | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||
Component: | Platform | Assignee: | Laszlo Gombos <laszlo.gombos> | ||||
Status: | CLOSED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dpranke, eric, hausmann, jturcotte | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 35784 | ||||||
Attachments: |
|
Description
Laszlo Gombos
2010-04-05 21:49:13 PDT
Created attachment 52607 [details]
proposed patch
Test for source files before building instead of relying on standalone_package config test.
This not only fixes the bug, but I think it also makes the build file more readable and potentially even allows to patch a package build with some goodies (e.g. Dumprendertree) from trunk sources.
I was not sure of the package build includes QtLauncher so I moved that build target to be optional (only build it if exists) as well.
Comment on attachment 52607 [details]
proposed patch
I'm OK with this change, but maybe Simon has objections, so clearing cq for now.
Attachment 52607 [details] was posted by a committer and has review+, assigning to Laszlo Gombos for commit.
Comment on attachment 52607 [details]
proposed patch
Looks okay to me :)
Comment on attachment 52607 [details] proposed patch Clearing flags on attachment: 52607 Committed r57198: <http://trac.webkit.org/changeset/57198> All reviewed patches have been landed. Closing bug. Revision r57198 cherry-picked into qtwebkit-2.0 with commit 90e8e997a968f72584c55f0006c09db0944a3e11 Committed r57290: <http://trac.webkit.org/changeset/57290> (In reply to comment #8) > Committed r57290: <http://trac.webkit.org/changeset/57290> grr. Ignore this. webkit-patch strikes again. |