Bug 37135

Summary:

Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Accessibility

Assignee:

Antonio Gomes <tonikitoo>

Status:

CLOSED FIXED

Severity:

Normal

CC:

hausmann, kenneth, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

18662

Bug Blocks:

35784

Attachments:

Description	Flags
(committed in r57211) patch	none

Description Antonio Gomes 2010-04-05 21:32:36 PDT

After calling distanceDataForNode, it is possible to verify if current focus candidate node is applicable or not to Spatial Navigation logic:

if it is not applicable , distanceDataForNode will assign a very big valur to node.distance (numeric_limits<long long int>::max()). It might happen when node is not in direction, for example, and indicates that current focus candidate is not an applicable focusable node.

In such cases, we should bail out earlier than later.

patch coming ...

Comment 1 Antonio Gomes 2010-04-05 21:40:33 PDT

Created attachment 52604 [details]
(committed in r57211) patch

Comment 2 Antonio Gomes 2010-04-11 20:06:28 PDT

Comment on attachment 52604 [details]
(committed in r57211) patch

Clearing flags on attachment: 52604

Committed r57211: <http://trac.webkit.org/changeset/57211>

Comment 3 Simon Hausmann 2010-04-20 13:16:32 PDT

Revision r57211 cherry-picked into qtwebkit-2.0 with commit ae6f9f4464f61661fafb5ef702659e47d82a89cc