Summary: | Web Inspector: Console with two recursive arrays causes infinite loop trying to display | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Timothy Hatcher
2010-04-05 20:05:57 PDT
Created attachment 52974 [details]
[PATCH] Proposed fix.
So what does the output actually look like now (not the dump'd output, but a screenshot of what shows up in the console)? Created attachment 52975 [details]
[IMAGE] Screenshot while running with patch.
Ohh, I like that. The patch also looks good to me. Lets see if I can r+ this. Comment on attachment 52974 [details] [PATCH] Proposed fix. > + Web Inspector: Console with two recursive arrays causes infinite loop trying to display. > + > + https://bugs.webkit.org/show_bug.cgi?id=37133 Nit: Please remove this blank line. (In reply to comment #5) > Nit: Please remove this blank line. It looks like sometimes you have this blank line, and sometimes you don't. So I tested what prepare-ChangeLog does: shell> prepare-ChangeLog -b 37133 Web Inspector: Console with two recursive arrays causes infinite loop trying to display https://bugs.webkit.org/show_bug.cgi?id=37133 I like this format, it chunks the sections together nicer. One more time without wrapping (sorry for the email spam)
> shell> prepare-ChangeLog -b 37133
>
> Web Inspector: Console with two recursive arrays causes infinite loop trying to display
> https://bugs.webkit.org/show_bug.cgi?id=37133
Created attachment 52976 [details]
[PATCH] Proposed fix with no blank line.
Created attachment 52977 [details]
[PATCH] Oh-ah, there were two change logs.
Comment on attachment 52977 [details] [PATCH] Oh-ah, there were two change logs. Rejecting patch 52977 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Pavel Feldman', '--force']" exit_code: 2 patching file LayoutTests/ChangeLog patch: **** malformed patch at line 18: patching file LayoutTests/inspector/console-format-collections-expected.txt patching file LayoutTests/inspector/console-format-collections.html patching file WebCore/ChangeLog patch: **** malformed patch at line 21: patching file WebCore/inspector/front-end/ConsoleView.js patching file WebCore/inspector/front-end/InjectedScript.js Full output: http://webkit-commit-queue.appspot.com/results/1696049 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/console-format-collections-expected.txt M LayoutTests/inspector/console-format-collections.html M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/InjectedScript.js Committed r57405 |