Bug 37094

Summary: [V8] SerializedScriptValue value doesn't follow the spec for DOM objects and files
Product: WebKit Reporter: Vitaly Repeshko <vitalyr>
Component: WebCore Misc.Assignee: Vitaly Repeshko <vitalyr>
Severity: Normal CC: eric, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
file types support patch v1
file types support patch v1.1: fixed style issue fishd: review+

Description Vitaly Repeshko 2010-04-05 09:38:12 PDT
Currently, SerializedScriptValue treats DOM objects and files as JS objects.
Comment 1 Vitaly Repeshko 2010-04-08 18:10:19 PDT
Created attachment 52927 [details]
file types support patch v1
Comment 2 WebKit Review Bot 2010-04-08 18:15:05 PDT
Attachment 52927 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/SerializedScriptValue.cpp:203:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Vitaly Repeshko 2010-04-08 18:27:36 PDT
Created attachment 52929 [details]
file types support patch v1.1: fixed style issue
Comment 4 Darin Fisher (:fishd, Google) 2010-04-08 19:46:40 PDT
Comment on attachment 52929 [details]
file types support patch v1.1: fixed style issue

Comment 5 Vitaly Repeshko 2010-04-09 16:30:29 PDT
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/SerializedScriptValue.cpp
Committed r57382

File types are done. Now we only need to reject DOM wrappers.
Comment 6 Eric Seidel (no email) 2010-04-18 16:28:54 PDT
Attachment 52929 [details] was posted by a committer and has review+, assigning to Vitaly Repeshko for commit.
Comment 7 Eric Seidel (no email) 2010-05-17 00:37:12 PDT
Closing since this was landed.
Comment 8 Eric Seidel (no email) 2010-05-17 00:37:28 PDT
Please open a new bug for any additional changes.