Bug 37068

Summary: Change UString to use a 0 rep for null strings instead a null object.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2010-04-03 21:33:15 PDT
(as per WebCore::String)
Attachments
The patch (6.73 KB, patch)
2010-04-03 21:34 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-04-03 21:34:57 PDT
Created attachment 52502 [details] The patch No performance impact
WebKit Review Bot
Comment 2 2010-04-03 21:36:50 PDT
Attachment 52502 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/runtime/UString.h:142: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/runtime/UString.h:142: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-04-03 22:19:47 PDT
Comment on attachment 52502 [details] The patch r=me, but you need to fix the style error in UString::cost
Gavin Barraclough
Comment 4 2010-04-03 23:54:14 PDT
Transmitting file data ...... Committed revision 57055.
Note You need to log in before you can comment on or make changes to this bug.