Bug 37040 – AX: need to send selected children change notification when aria-selected changed

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

when aria-selected changes, webkit should send out the notification

[chris fleizach]

Created attachment 52556 [details]
patch

[Darin Adler]

Comment on attachment 52556 [details]
patch

> +    bool nodeIsAriaType(Node*, String role);

The type should be const String&. If the term for the argument really role, then I'd think you'd want it to be called nodeHasRole rather than nodeIsAriaType. Or nodeHasARIAType.

> -        if (renderer->isTextControl())
> -            return renderer->document()->axObjectCache()->getOrCreate(renderer);
> +        if (renderer->isTextControl() 
> +            || (renderer->isListBox() || axObjectCache()->nodeIsAriaType(renderer->node(), "listbox")))
> +            return axObjectCache()->getOrCreate(renderer);

This seems like a pretty strange set of conditions. I think this rule should be implemented with a helper function, just to give you a place to put a comment. And the comment can explain why these three things are special.

> +    AccessibilityChildrenVector childObjects = children();
> +    for (unsigned k = 0, childrenSize = childObjects.size(); k < childrenSize; ++k) {

Normally we'd just initialize childrenSize outside the loop. It's neat to have it scoped like this, but clearer written the more-conventional way.

[chris fleizach]

made changes darin requested
http://trac.webkit.org/changeset/57093

[chris fleizach]

this caused aria-live region to fail on leopard again. it must be something with that test, because it looks like we can't add new tests. i will look at that test now

[chris fleizach]

why this only fails on leopard release bot is baffling

[chris fleizach]

disabling this test on leopard for now
https://bugs.webkit.org/show_bug.cgi?id=37112

[WebKit Review Bot]

http://trac.webkit.org/changeset/57093 might have broken Tiger Intel Release

[Adam Barth]

> http://trac.webkit.org/changeset/57093 might have broken Tiger Intel Release

This is svg/custom/getsvgdocument.html, which has recently become very flaky.  I don't think it's related to your change.