Bug 37023 – [Qt] Expose HTMLTokenizer yielding parameters

• Component: WebKit Qt
• Status: CLOSED FIXED

[Laszlo Gombos]

These interfaces are useful in CPU-contained environments. Similar interface is exposed in Safari.

[Laszlo Gombos]

Created attachment 52415 [details]
proposed patch

[Kenneth Rohde Christiansen]

Laszlo should this patch be integrated in our 2.0 release branch after landing on trunk? if so, please add it as blocker.

[Laszlo Gombos]

Comment on attachment 52415 [details]
proposed patch

Changed mind, let's use DynamicProperties instead.

[Laszlo Gombos]

Created attachment 54667 [details]
2nd try, using DynamicProperties

[Simon Hausmann]

Comment on attachment 54667 [details]
2nd try, using DynamicProperties

> Index: WebKit/qt/ChangeLog
> ===================================================================
> --- WebKit/qt/ChangeLog	(revision 58467)
> +++ WebKit/qt/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> [phone]  Laszlo Gombos  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Expose HTMLTokenizer yielding parameters
> +        https://bugs.webkit.org/show_bug.cgi?id=37023
> +
> +        Enables to set TimeDelay and ChunkSize for 
> +        HTMLTokenizer.
> +
> +        * Api/qwebpage.cpp:
> +        (QWebPagePrivate::dynamicPropertyChangeEvent):
> +
>  2010-04-28  Laszlo Gombos  <[e-mail]>
>  
>          Unreviewed, Qt build fix.
> Index: WebKit/qt/Api/qwebpage.cpp
> ===================================================================
> --- WebKit/qt/Api/qwebpage.cpp	(revision 58462)
> +++ WebKit/qt/Api/qwebpage.cpp	(working copy)
> @@ -1219,6 +1219,14 @@ void QWebPagePrivate::dynamicPropertyCha
>              view->forceLayout();
>          }
>      }
> +    else if (event->propertyName() == "HTMLTokenizerChunkSize") {
> +        int chunkSize = q->property("HTMLTokenizerChunkSize").toInt();
> +        q->handle()->page->setCustomHTMLTokenizerChunkSize(chunkSize);
> +    }
> +    else if (event->propertyName() == "HTMLTokenizerTimeDelay") {
> +        double timeDelay = q->property("HTMLTokenizerTimeDelay").toDouble();
> +        q->handle()->page->setCustomHTMLTokenizerTimeDelay(timeDelay);
> +    }
>  }
>  
>  void QWebPagePrivate::shortcutOverrideEvent(QKeyEvent* event)
WebKit/qt/Api/qwebpage.cpp:1222
 +      else if (event->propertyName() == "HTMLTokenizerChunkSize") {
Shouldn't the else be merged with the previous line? :)

WebKit/qt/Api/qwebpage.cpp:1230
 +  }
It would be nice to call the base implementation here, just for future proofing.

[Simon Hausmann]

Do you want this patch in the 2.0 release?

[Eric Seidel (no email)]

Attachment 54667 [details] was posted by a committer and has review+, assigning to Laszlo Gombos for commit.

[Laszlo Gombos]

Comment on attachment 54667 [details]
2nd try, using DynamicProperties

Committed as http://trac.webkit.org/changeset/58727 with the style change pointed out by Simon. In addition prefixed the property names with _q_ as discussed in bug 38119.

[Laszlo Gombos]

(In reply to comment #6)
> Do you want this patch in the 2.0 release?

Yes, please.

[Simon Hausmann]

<cherry-pick-for-backport: r58727>

[Simon Hausmann]

Revision r58727 cherry-picked into qtwebkit-2.0 with commit af21ac4af5aee469e8ea1334b0dc56f26d7aa180