Bug 36994

Summary: Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2010-04-01 17:25:03 PDT
FrameView::scrollPositionChanged() does some widget updating, and compositing layer updating that is unnecessary if there are no fixed position elements. And, thanks to bug 33150, we know if the FrameView contains fixed position objects.
Attachments
Patch (1.97 KB, patch)
2010-04-01 17:47 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-04-01 17:47:34 PDT
Created attachment 52358 [details] Patch
Darin Adler
Comment 2 2010-04-01 19:45:03 PDT
Comment on attachment 52358 [details] Patch > + bool hasFixedObjects() const { return m_fixedObjectCount > 0; } Since this is used only inside the class, can we make the function private? Members generally should be as private as possible. Or maybe just say && m_fixedObjectCount at the call site? r=me
Simon Fraser (smfr)
Comment 3 2010-04-02 10:41:23 PDT
http://trac.webkit.org/changeset/57009
Note You need to log in before you can comment on or make changes to this bug.