Bug 36985

Summary: webkit-patch can incorrectly think the working directory is modified
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Ojan Vafai
Reported 2010-04-01 15:59:16 PDT
webkit-patch can incorrectly think the working directory is modified
Attachments
Patch (1.47 KB, patch)
2010-04-01 16:00 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2010-04-01 16:46 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-04-01 16:00:39 PDT
Created attachment 52346 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-01 16:03:11 PDT
Comment on attachment 52346 [details] Patch I think git svn needs this too! git svn rebase seems to fail to "you need to update" commonly even when I don't need to. We need to test this though.
WebKit Review Bot
Comment 3 2010-04-01 16:05:45 PDT
Attachment 52346 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ojan Vafai
Comment 4 2010-04-01 16:46:47 PDT
Created attachment 52352 [details] Patch
Ojan Vafai
Comment 5 2010-04-01 16:49:23 PDT
Committed r56950: <http://trac.webkit.org/changeset/56950>
Note You need to log in before you can comment on or make changes to this bug.