Bug 36985

Summary: webkit-patch can incorrectly think the working directory is modified
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Description Ojan Vafai 2010-04-01 15:59:16 PDT
webkit-patch can incorrectly think the working directory is modified
Comment 1 Ojan Vafai 2010-04-01 16:00:39 PDT
Created attachment 52346 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-01 16:03:11 PDT
Comment on attachment 52346 [details]
Patch

I think git svn needs this too!  git svn rebase seems to fail to "you need to update" commonly even when I don't need to.

We need to test this though.
Comment 3 WebKit Review Bot 2010-04-01 16:05:45 PDT
Attachment 52346 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ojan Vafai 2010-04-01 16:46:47 PDT
Created attachment 52352 [details]
Patch
Comment 5 Ojan Vafai 2010-04-01 16:49:23 PDT
Committed r56950: <http://trac.webkit.org/changeset/56950>