Summary: | REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Plug-ins | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin | ||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac (Intel) | ||||||||
OS: | OS X 10.6 | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2010-04-01 12:13:52 PDT
Created attachment 52323 [details]
proposed fix
Comment on attachment 52323 [details]
proposed fix
r=me
Comment on attachment 52323 [details] proposed fix > + (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(), > + because the latter fails with an assertion when looking up 0 or -1. Why doesn't find() fail with an assertion looking up 0 or -1? Makes no sense to me that it would not. Committed <http://trac.webkit.org/changeset/56932>. That's because find() has an early return if m_table is null, and get() doesn't. You are right, the first part of this change is incorrect. Created attachment 52326 [details]
more fixes
Comment on attachment 52326 [details]
more fixes
r=me
Follow-up committed <http://trac.webkit.org/changeset/56935>. |