Summary: | [Chromium]: FindInPage issue with focus remaining on element after match is found | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Finnur Thorarinsson <finnur.webkit> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, progame+wk, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Finnur Thorarinsson
2010-03-31 19:40:50 PDT
Created attachment 52243 [details]
Patch for Find issue 36923
Attachment 52243 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebFrameImpl.cpp:1327: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 52245 [details]
Now with style issue fixed
Comment on attachment 52245 [details] Now with style issue fixed Code looks correct to me. > Index: WebKit/chromium/ChangeLog > =================================================================== > --- WebKit/chromium/ChangeLog (revision 56886) > +++ WebKit/chromium/ChangeLog (working copy) > @@ -1,3 +1,15 @@ > +2010-03-31 Finnur Thorarinsson <finnur.webkit@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [chromium] FindInPage should clear the focused node when a match has > + been found. > + > + https://bugs.webkit.org/show_bug.cgi?id=36923 Would be nice to have a description here about how this fixes the bug, i.e. that WebFrameImpl::setFocus will try to refocus editable elements if it thinks they have focus, causing the page to scroll. Created attachment 52303 [details]
Updated description
Comment on attachment 52303 [details]
Updated description
ok.
Comment on attachment 52303 [details] Updated description Clearing flags on attachment: 52303 Committed r56917: <http://trac.webkit.org/changeset/56917> All reviewed patches have been landed. Closing bug. |