Summary: | [Chromium] WebFrame should have a method to execute script and return the evaluated value | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jay Campan <jcampan> | ||||||
Component: | WebKit API | Assignee: | Jay Campan <jcampan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, fishd | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jay Campan
2010-03-31 16:23:33 PDT
Created attachment 52221 [details]
Adding a method to WebFrame to evaluate a JS expression.
Seems like a good idea to me, but Adam, Dimitry or Darin are better reviewers for this sort of change. Comment on attachment 52221 [details] Adding a method to WebFrame to evaluate a JS expression. > Index: WebKit/chromium/public/WebFrame.h ... > namespace v8 { > class Context; > +template <class T> class Handle; > template <class T> class Local; > +class Value; > + > } nit: please change the above to: namespace v8 { class Context; class Value; template <class T> class Handle; template <class T> class Local; } with that, R=me Created attachment 52350 [details]
Fixing class name order
Comment on attachment 52350 [details]
Fixing class name order
Based on Darin's previous r+ and validating that the requested change was done.
I take it we don't have a ScriptController in the WebKit API. :) Comment on attachment 52350 [details] Fixing class name order Clearing flags on attachment: 52350 Committed r56972: <http://trac.webkit.org/changeset/56972> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > I take it we don't have a ScriptController in the WebKit API. :) Well, we do have WebScriptController, but it only has static functions. It is used for registering V8 extensions and performing some other operations. It isn't an instantiated class in the WebKit API. We could change that if it would help make things clearer. |