REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

1. Visit boxofficemojo.com
2. Scroll the page vertically

Results: The tops of the Flash ads at the top and along the right side of the page are clipped out.

This happens when using the version of Flash that currently ships with Mac OS X.

<rdar://problem/7804018>

[Alexey Proskuryakov]

Created attachment 52197 [details]
proposed fix

Comment on attachment 52197 [details]
proposed fix

Thanks for fixing this!

> +    IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so storing it in frame view coordinates, and not clipped to window.

I would say “content view coordinates”.

r=me

[Eric Seidel (no email)]

Attachment 52197 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1612107

[Darin Adler]

Comment on attachment 52197 [details]
proposed fix

> +#include "CString.h"

Please don't add this. Or you could state why you need to add it.

> -    IntRect m_windowClipRect;
> +    IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so storing it in frame view coordinates, and not clipped to window.

I would say "it is stored" rather than "storing it" here.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/56858>.

[Simon Fraser (smfr)]

Comment on attachment 52197 [details]
proposed fix


> Index: WebCore/rendering/RenderWidget.cpp

> +#include "CString.h"

Was this an intentional part of the change?

[Alexey Proskuryakov]

Addressed additional review comments in <http://trac.webkit.org/changeset/56859>.