Bug 36897

Summary: REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Layout and RenderingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mitz
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
proposed fix mitz: review+

Alexey Proskuryakov
Reported 2010-03-31 12:09:19 PDT
1. Visit boxofficemojo.com 2. Scroll the page vertically Results: The tops of the Flash ads at the top and along the right side of the page are clipped out. This happens when using the version of Flash that currently ships with Mac OS X. <rdar://problem/7804018>
Attachments
proposed fix (6.25 KB, patch)
2010-03-31 12:40 PDT, Alexey Proskuryakov
mitz: review+
Alexey Proskuryakov
Comment 1 2010-03-31 12:40:31 PDT
Created attachment 52197 [details] proposed fix
mitz
Comment 2 2010-03-31 12:42:58 PDT
Comment on attachment 52197 [details] proposed fix Thanks for fixing this! > + IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so storing it in frame view coordinates, and not clipped to window. I would say “content view coordinates”. r=me
Eric Seidel (no email)
Comment 3 2010-03-31 12:44:10 PDT
Darin Adler
Comment 4 2010-03-31 12:44:21 PDT
Comment on attachment 52197 [details] proposed fix > +#include "CString.h" Please don't add this. Or you could state why you need to add it. > - IntRect m_windowClipRect; > + IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so storing it in frame view coordinates, and not clipped to window. I would say "it is stored" rather than "storing it" here.
Alexey Proskuryakov
Comment 5 2010-03-31 12:49:18 PDT
Simon Fraser (smfr)
Comment 6 2010-03-31 13:06:25 PDT
Comment on attachment 52197 [details] proposed fix > Index: WebCore/rendering/RenderWidget.cpp > +#include "CString.h" Was this an intentional part of the change?
Alexey Proskuryakov
Comment 7 2010-03-31 13:12:45 PDT
Addressed additional review comments in <http://trac.webkit.org/changeset/56859>.
Note You need to log in before you can comment on or make changes to this bug.