Summary: | webkitpy: Refactor two os.path.relpath() replacements to use the same method | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||
Component: | Tools / Tests | Assignee: | Chris Jerdonek <cjerdonek> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cjerdonek, eric, hamaji | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Chris Jerdonek
2010-03-31 10:18:59 PDT
Created attachment 52185 [details]
Proposed patch
FYI, I added a section to this page about consequences of not using Python 2.6: http://trac.webkit.org/wiki/PythonGuidelines Comment on attachment 52185 [details]
Proposed patch
YAY! But what the heck is "opsys". Seems like a strange module name.
Seems like we should update that page to say that our scripts require 2.5, period. (In reply to comment #3) > (From update of attachment 52185 [details]) > YAY! But what the heck is "opsys". Seems like a strange module name. Operating system. My preference was "os", but that presented problems for other modules in the package calling "import os". I'm open to other suggestions. (In reply to comment #4) > Seems like we should update that page to say that our scripts require 2.5, > period. Thanks -- yeah, I just noticed that, too. I'll change it. Why not just call the module relpath? (In reply to comment #7) > Why not just call the module relpath? I thought about that, but then figured there was going to be at least one more os-related method at some point. I suppose we can always rename the file. I'll change it to relpath. Comment on attachment 52185 [details]
Proposed patch
cq- so I can rename the file to relpath.
Maybe a name to designate that we're expanding on missing pieces of OS, like osadditions or something like that if that would be more clear than osys/relpath? In the end it doesn't matter. Feel free to name it as you choose. :) Committed: http://trac.webkit.org/changeset/56870 I split the difference between os and relpath and chose ospath. |