Bug 36877

Summary: Web inspector will only display cookies for (file|http[s]?) resources
Product: WebKit Reporter: Mattias Nissler <mnissler>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jorlow, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
patch none

Mattias Nissler
Reported 2010-03-31 02:23:10 PDT
Currently, web inspector explicitly filters the resource URLs it will display cookies for to only include file, http and https URLs. Thus, when using the inspector on some other resource (e.g. a chrome extension), it won't display any cookies even if there are some.
Attachments
Patch (3.08 KB, patch)
2010-03-31 02:33 PDT, Mattias Nissler 		no flags
DetailsFormatted DiffDiff
patch (3.06 KB, patch)
2010-03-31 06:07 PDT, Mattias Nissler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mattias Nissler
Comment 1 2010-03-31 02:33:02 PDT
Created attachment 52146 [details] Patch
Pavel Feldman
Comment 2 2010-03-31 04:55:42 PDT
Comment on attachment 52146 [details] Patch > + this._addCookieDomain(match[2] ? match[2] : ""); > } I think you can simplify it even further due to (match[2] ? match[2] : "") === match[2]
Mattias Nissler
Comment 3 2010-03-31 06:07:28 PDT
Created attachment 52154 [details] patch
Mattias Nissler
Comment 4 2010-03-31 06:08:50 PDT
(In reply to comment #2) > I think you can simplify it even further due to > > (match[2] ? match[2] : "") === match[2] Considering that a successful match of the regex always gives us a defined match[2], that's correct. Didn't think of that, thanks.(In reply to comment #2)
WebKit Commit Bot
Comment 5 2010-03-31 07:45:36 PDT
Comment on attachment 52154 [details] patch Clearing flags on attachment: 52154 Committed r56840: <http://trac.webkit.org/changeset/56840>
WebKit Commit Bot
Comment 6 2010-03-31 07:45:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.