Summary: | Web inspector will only display cookies for (file|http[s]?) resources | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mattias Nissler <mnissler> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jorlow, pfeldman | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mattias Nissler
2010-03-31 02:23:10 PDT
Created attachment 52146 [details]
Patch
Comment on attachment 52146 [details] Patch > + this._addCookieDomain(match[2] ? match[2] : ""); > } I think you can simplify it even further due to (match[2] ? match[2] : "") === match[2] Created attachment 52154 [details]
patch
(In reply to comment #2) > I think you can simplify it even further due to > > (match[2] ? match[2] : "") === match[2] Considering that a successful match of the regex always gives us a defined match[2], that's correct. Didn't think of that, thanks.(In reply to comment #2) Comment on attachment 52154 [details] patch Clearing flags on attachment: 52154 Committed r56840: <http://trac.webkit.org/changeset/56840> All reviewed patches have been landed. Closing bug. |