Bug 36870

Summary: [Qt] WebKit crashes while input text through input method
Product: WebKit Reporter: Tasuku Suzuki <tasuku.suzuki>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Critical CC: commit-queue, hausmann, joseph.ligman
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Minimal test case for this issue
none
proposed patch none

Tasuku Suzuki
Reported 2010-03-30 22:28:03 PDT
Created attachment 52128 [details] Minimal test case for this issue QtWebKit crashes when I input text through input method on Windows 7, Mac OS X and Ubuntu Linux. 1. Launch Demo Browser in Qt. 2. Open google.com 3. Input "aiueo" in Japanese with Japanese IME 4. Translate it to Kanji. I'm sure this is not a language specific. Please see and run the minimal test case attached.
Attachments
Minimal test case for this issue (1.92 KB, text/plain)
2010-03-30 22:28 PDT, Tasuku Suzuki 		no flags
Details
proposed patch (4.51 KB, patch)
2010-04-06 20:26 PDT, Joseph Ligman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Ligman
Comment 1 2010-04-06 20:26:51 PDT
Created attachment 52697 [details] proposed patch I did some debugging with your test case and noticed that the problem could be with the underline start and end offset.
Tasuku Suzuki
Comment 2 2010-04-07 01:26:55 PDT
(In reply to comment #1) > Created an attachment (id=52697) [details] > proposed patch > > I did some debugging with your test case and noticed that the problem could be > with the underline start and end offset. I see that the problem was QWebPage passed start and length to CompositionUnderline instead of start and end. As far as I tested for a while, your patch works for me on Windows 7, Mac OS X(10.6) and Gentoo Linux.
Joseph Ligman
Comment 3 2010-04-07 06:44:54 PDT
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=52697) [details] [details] > > proposed patch > > > > I did some debugging with your test case and noticed that the problem could be > > with the underline start and end offset. > > I see that the problem was QWebPage passed start and length to > CompositionUnderline instead of start and end. > As far as I tested for a while, your patch works for me on Windows 7, Mac OS > X(10.6) and Gentoo Linux. Thanks. I will set the patch for review.
Simon Hausmann
Comment 4 2010-04-08 06:11:13 PDT
Comment on attachment 52697 [details] proposed patch r=me
WebKit Commit Bot
Comment 5 2010-04-08 06:24:32 PDT
Comment on attachment 52697 [details] proposed patch Clearing flags on attachment: 52697 Committed r57270: <http://trac.webkit.org/changeset/57270>
WebKit Commit Bot
Comment 6 2010-04-08 06:24:37 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 7 2010-04-09 01:14:07 PDT
Revision r57270 cherry-picked into qtwebkit-2.0 with commit b607ff42345b89dfcd328c95740491e8f9eeb367
Note You need to log in before you can comment on or make changes to this bug.