| Summary: | [Qt] WebKit crashes while input text through input method | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tasuku Suzuki <tasuku.suzuki> | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | CLOSED FIXED | ||||||||
| Severity: | Critical | CC: | commit-queue, hausmann, joseph.ligman | ||||||
| Priority: | P2 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 35784 | ||||||||
| Attachments: |
|
||||||||
Created attachment 52697 [details]
proposed patch
I did some debugging with your test case and noticed that the problem could be with the underline start and end offset.
(In reply to comment #1) > Created an attachment (id=52697) [details] > proposed patch > > I did some debugging with your test case and noticed that the problem could be > with the underline start and end offset. I see that the problem was QWebPage passed start and length to CompositionUnderline instead of start and end. As far as I tested for a while, your patch works for me on Windows 7, Mac OS X(10.6) and Gentoo Linux. (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=52697) [details] [details] > > proposed patch > > > > I did some debugging with your test case and noticed that the problem could be > > with the underline start and end offset. > > I see that the problem was QWebPage passed start and length to > CompositionUnderline instead of start and end. > As far as I tested for a while, your patch works for me on Windows 7, Mac OS > X(10.6) and Gentoo Linux. Thanks. I will set the patch for review. Comment on attachment 52697 [details]
proposed patch
r=me
Comment on attachment 52697 [details] proposed patch Clearing flags on attachment: 52697 Committed r57270: <http://trac.webkit.org/changeset/57270> All reviewed patches have been landed. Closing bug. |
Created attachment 52128 [details] Minimal test case for this issue QtWebKit crashes when I input text through input method on Windows 7, Mac OS X and Ubuntu Linux. 1. Launch Demo Browser in Qt. 2. Open google.com 3. Input "aiueo" in Japanese with Japanese IME 4. Translate it to Kanji. I'm sure this is not a language specific. Please see and run the minimal test case attached.