Bug 36865 – path to committers.py in commit-queue rejection message is wrong

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

path to committers.py in commit-queue rejection message is wrong

Right now it's hardcoded in CommitterValidator (inside bugzilla.py)

        committer_list = "WebKitTools/Scripts/webkitpy/committers.py"

I havne't yet found the magic for computing the __file__ dynamically.

You can get the __file__ from a module object, but we import just the class and not the module.

You can get the module name (string) from classname.__module__ or
instance.__class__.__module__

But I don't yet know how to get to the actual module object.

If we moved towards a model where we used:
import committers

statements instead of:

from committers import CommitterList

then we could easily just grab "committers.__file__" and be done. :)

[Chris Jerdonek]

(In reply to comment #0)
> If we moved towards a model where we used:
> import committers
> 
> statements instead of:
> 
> from committers import CommitterList
> 
> then we could easily just grab "committers.__file__" and be done. :)

Why wouldn't you want to do "import committers" if you need it?

Also, have you tried

from committers import __file__?

(Not sure if that would work.)

[Chris Jerdonek]

(In reply to comment #1)
> from committers import __file__?
> 
> (Not sure if that would work.)

Or better is probably--

from committers import __file__ as _committers_file

[Chris Jerdonek]

(In reply to comment #2)
> Or better is probably--
> 
> from committers import __file__ as _committers_file

Yes, this works.  But since it can return the .pyc file if it exists, you probably want to normalize the extension to .py.

[Eric Seidel (no email)]

Created attachment 52140 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 52140 [details]
Patch

I am completely covered in Yak hair.

[Adam Barth]

Comment on attachment 52140 [details]
Patch

This code is really wrong, but ok.

/WebKitTools/svn/WebKitTools/Scripts/webkitpy

[WebKit Commit Bot]

Comment on attachment 52140 [details]
Patch

Clearing flags on attachment: 52140

Committed r56835: <http://trac.webkit.org/changeset/56835>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.