Bug 36858

Summary:

Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

Layout and Rendering

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, eric, mitz

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Enrica Casucci 2010-03-30 15:46:11 PDT

Fails to handle properly characters with multiple glyphs.

Repro steps:

1. Go to http://www.mozilla.org/editor/midasdemo/
2. Type thai characters คำ

Expected:
The caret is placed next to the second character.

Actual:
The caret disappears.

Comment 1 Enrica Casucci 2010-03-30 15:55:20 PDT

Created attachment 52093 [details]
Patch

Comment 2 Darin Adler 2010-03-30 16:06:12 PDT

Comment on attachment 52093 [details]
Patch

> +        Incorrect insertion position after typing 'à¸³' (THAI CHARACTER SARA AM = 0E33)

You probably should not put the character itself in the change log. People might not open it in the right way to view UTF-8 characters. We usually stick to ASCII for the change log itself.

r=me

Comment 3 Eric Seidel (no email) 2010-03-31 15:29:28 PDT

This appears to have caused fast/text/multiglyph-characters.html to fail on Tiger.

Comment 4 Eric Seidel (no email) 2010-03-31 23:33:45 PDT

Comment on attachment 52093 [details]
Patch

Looks like this was landed in http://trac.webkit.org/changeset/56813.  I'll leave this open since Tiger is currently broken, but otherwise it could be closed.

Comment 5 Eric Seidel (no email) 2010-04-01 17:29:25 PDT

Should I check in the failing results for Tiger?

Comment 6 Eric Seidel (no email) 2010-04-02 00:09:43 PDT

Created attachment 52386 [details]
Patch

Comment 7 Eric Seidel (no email) 2010-04-02 00:10:58 PDT

Comment on attachment 52386 [details]
Patch

I've prepared a checkin with the failing result for tiger pulled from the Tiger bot.  Please let me know if this is not what's desired.  Either way we need to make the Tiger bot green again so we can catch any subsequent regressions.

Comment 8 WebKit Commit Bot 2010-04-02 10:01:53 PDT

Comment on attachment 52386 [details]
Patch

Clearing flags on attachment: 52386

Committed r57006: <http://trac.webkit.org/changeset/57006>

Comment 9 WebKit Commit Bot 2010-04-02 10:01:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 10 David Kilzer (:ddkilzer) 2010-04-17 11:44:40 PDT

<rdar://problem/7693772>