Bug 36855

Summary:

Let non-git users on Windows configure Bugzilla passwords for webkit-patch

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Windows Vista

Attachments:

Description	Flags
Patch	abarth: review-

Adam Barth

Reported 2010-03-30 15:00:14 PDT

Let non-git users on Windows configure Bugzilla passwords for webkit-patch

Attachments
Patch (9.34 KB, patch) 2010-03-30 15:05 PDT, Adam Barth	abarth: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-03-30 15:05:42 PDT

Created attachment 52086 [details] Patch

Eric Seidel (no email)

Comment 2 2010-03-30 15:08:50 PDT

Why not just autoinstall http://pypi.python.org/pypi/keyring/ instead of inventing yet another config system? We already use git config when available.

Eric Seidel (no email)

Comment 3 2010-03-30 15:09:33 PDT

are we modifying simplejson or can we autoinstall that too?

Adam Barth

Comment 4 2010-03-30 15:13:32 PDT

Comment on attachment 52086 [details] Patch DIdn't know keyring existed. Will investigate. As I said in the ChangeLog: + I tried using autoinstall, but I + couldn't get it to work. I think autoinstall is the long term + solution here, assuming it works.

Adam Barth

Comment 5 2010-03-30 15:17:49 PDT

Comment on attachment 52086 [details] Patch Actually, it looks like keyring is solving a different problem: integrating with existing encrypted password stores. That's not the problem I'm trying to solve. I'm trying to solve the problem of configuring webkit-patch somewhere other than the command line. For example, keyring doesn't let me store the username.

Adam Barth

Comment 6 2010-03-30 15:34:53 PDT

Comment on attachment 52086 [details] Patch Ok. I hate this patch. We should find a better way.

Eric Seidel (no email)

Comment 7 2010-03-30 15:37:37 PDT

:/ ?

Note You need to log in before you can comment on or make changes to this bug.