Bug 36816

Summary: Uninitalised members in BytecodeGenerator and CallLinkInfo
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Balazs Kelemen
Reported 2010-03-30 05:23:53 PDT
Valgrind shows me 2 uninitalised value problem: Conditional jump or move depends on uninitialised value(s) at 0x51BBB60: cti_vm_lazyLinkCall (JITStubs.cpp:1679) by 0x51B0102: JSC::TrampolineStructure::TrampolineStructure() (JITStubs.h:76) by 0x5173A5C: JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*, JSC::JSValue*) (JITCode.h:77) ... Conditional jump or move depends on uninitialized value(s) at 0x513E0DF: JSC::BytecodeGenerator::createArgumentsIfNecessary() (BytecodeGenerator.cpp:1391) by 0x5147EE7: JSC::BytecodeGenerator::emitPushNewScope(JSC::RegisterID*, JSC::Identifier const&, JSC::RegisterID*) BytecodeGenerator.cpp:1882) by 0x5154205: JSC::TryNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) (NodesCodegen.cpp:1890) ... These are caused by incomplete member initializer lists. I think the second could be dangerous. Fortunately we can solve it by an easy fix.
Attachments
proposed patch (1.72 KB, patch)
2010-03-30 05:34 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-03-30 05:34:39 PDT
Created attachment 52025 [details] proposed patch
Darin Adler
Comment 2 2010-03-30 11:52:37 PDT
Comment on attachment 52025 [details] proposed patch Why does this need to be changed? Is there a symptom to having these uninitialized? Are they ever used uninitialized?
Balazs Kelemen
Comment 3 2010-03-30 15:40:57 PDT
The backtraces above shows exactly where are they used uninitialized.
Oliver Hunt
Comment 4 2010-04-03 18:04:00 PDT
Comment on attachment 52025 [details] proposed patch r=me
WebKit Commit Bot
Comment 5 2010-04-03 18:17:19 PDT
Comment on attachment 52025 [details] proposed patch Clearing flags on attachment: 52025 Committed r57054: <http://trac.webkit.org/changeset/57054>
WebKit Commit Bot
Comment 6 2010-04-03 18:17:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.