Bug 36773

Summary:

Spatial Navigation: proper handle negative x or y coordinates

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Accessibility

Assignee:

Antonio Gomes <tonikitoo>

Status:

CLOSED FIXED

Severity:

Normal

CC:

abarth, eric, hausmann, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

18662, 36168

Bug Blocks:

35784, 36463

Attachments:

Description	Flags
(committed in r57304) Patch 1	none

Antonio Gomes

Reported 2010-03-29 13:01:55 PDT

In Spatial Navigation logic, during rect acquisition of a node candidate to get focus, sometimes it gets negative x() or y() values, and algorithm currently bails out if any of this values is negative. however, when a node is in a scrollable content (content overflow <div>) and this scrollable container scrolled up, element gets offscreen, and gets negative values. In such cases, however, they are still valid to be used in Spatial Navigation logic. following patch addresses that.

Attachments
(committed in r57304) Patch 1 (8.63 KB, patch) 2010-03-29 13:10 PDT, Antonio Gomes	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antonio Gomes

Comment 1 2010-03-29 13:10:45 PDT

Created attachment 51955 [details] (committed in r57304) Patch 1 I will request review as soon as bug 36168 (its blocker) lands.

Antonio Gomes

Comment 2 2010-04-04 20:04:53 PDT

Comment on attachment 51955 [details] (committed in r57304) Patch 1 Requesting review, now that the blocker patch for this one has landed (see bug 36168 / r57061).

Antonio Gomes

Comment 3 2010-04-08 16:41:56 PDT

Comment on attachment 51955 [details] (committed in r57304) Patch 1 thank you simon/smfr!

WebKit Review Bot

Comment 4 2010-04-08 17:12:45 PDT

http://trac.webkit.org/changeset/57304 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/57304 http://trac.webkit.org/changeset/57301 http://trac.webkit.org/changeset/57302 http://trac.webkit.org/changeset/57303

Adam Barth

Comment 5 2010-04-08 17:20:50 PDT

Sorry for the sheriffbot spam. We're fighting through storage/open-database-creation-callback.html.

Antonio Gomes

Comment 6 2010-04-11 20:05:30 PDT

Comment on attachment 51955 [details] (committed in r57304) Patch 1 Clearing flags on attachment: 51955 Committed r57304: <http://trac.webkit.org/changeset/57304>

Simon Hausmann

Comment 7 2010-04-20 13:20:41 PDT

Revision r57304 cherry-picked into qtwebkit-2.0 with commit 3875bf5b10eecc016f2c324f5b612c62202a504c

Note You need to log in before you can comment on or make changes to this bug.