Bug 36773

Summary: Spatial Navigation: proper handle negative x or y coordinates
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: CLOSED FIXED    
Severity: Normal CC: abarth, eric, hausmann, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 18662, 36168    
Bug Blocks: 35784, 36463    
Description Flags
(committed in r57304) Patch 1 none

Description Antonio Gomes 2010-03-29 13:01:55 PDT
In Spatial Navigation logic, during rect acquisition of a node candidate to get focus, sometimes it gets negative x() or y() values, and algorithm currently bails out if any of this values is negative.

however, when a node is in a scrollable content (content overflow <div>) and this scrollable container scrolled up, element gets  offscreen, and gets negative values. In such cases, however, they are still valid to be used in Spatial Navigation logic.

following patch addresses that.
Comment 1 Antonio Gomes 2010-03-29 13:10:45 PDT
Created attachment 51955 [details]
(committed in r57304) Patch 1

I will request review as soon as bug 36168 (its blocker) lands.
Comment 2 Antonio Gomes 2010-04-04 20:04:53 PDT
Comment on attachment 51955 [details]
(committed in r57304) Patch 1

Requesting review, now that the blocker patch for this one has landed (see bug 36168 / r57061).
Comment 3 Antonio Gomes 2010-04-08 16:41:56 PDT
Comment on attachment 51955 [details]
(committed in r57304) Patch 1

thank you simon/smfr!
Comment 5 Adam Barth 2010-04-08 17:20:50 PDT
Sorry for the sheriffbot spam.  We're fighting through storage/open-database-creation-callback.html.
Comment 6 Antonio Gomes 2010-04-11 20:05:30 PDT
Comment on attachment 51955 [details]
(committed in r57304) Patch 1

Clearing flags on attachment: 51955

Committed r57304: <http://trac.webkit.org/changeset/57304>
Comment 7 Simon Hausmann 2010-04-20 13:20:41 PDT
Revision r57304 cherry-picked into qtwebkit-2.0 with commit 3875bf5b10eecc016f2c324f5b612c62202a504c