Spatial Navigation: proper handle negative x or y coordinates

• Component: Accessibility
• Status: CLOSED FIXED

[Antonio Gomes]

In Spatial Navigation logic, during rect acquisition of a node candidate to get focus, sometimes it gets negative x() or y() values, and algorithm currently bails out if any of this values is negative.

however, when a node is in a scrollable content (content overflow <div>) and this scrollable container scrolled up, element gets  offscreen, and gets negative values. In such cases, however, they are still valid to be used in Spatial Navigation logic.

following patch addresses that.

[Antonio Gomes]

Created attachment 51955 [details]
(committed in r57304) Patch 1

I will request review as soon as bug 36168 (its blocker) lands.

[Antonio Gomes]

Comment on attachment 51955 [details]
(committed in r57304) Patch 1

Requesting review, now that the blocker patch for this one has landed (see bug 36168 / r57061).

[Antonio Gomes]

Comment on attachment 51955 [details]
(committed in r57304) Patch 1

thank you simon/smfr!

[WebKit Review Bot]

http://trac.webkit.org/changeset/57304 might have broken Tiger Intel Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/57304
http://trac.webkit.org/changeset/57301
http://trac.webkit.org/changeset/57302
http://trac.webkit.org/changeset/57303

[Adam Barth]

Sorry for the sheriffbot spam.  We're fighting through storage/open-database-creation-callback.html.

[Antonio Gomes]

Comment on attachment 51955 [details]
(committed in r57304) Patch 1

Clearing flags on attachment: 51955

Committed r57304: <http://trac.webkit.org/changeset/57304>

[Simon Hausmann]

Revision r57304 cherry-picked into qtwebkit-2.0 with commit 3875bf5b10eecc016f2c324f5b612c62202a504c