Bug 36748

Summary: [Qt] Webkit for symbian building fails
Product: WebKit Reporter: t.zander
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
patch
hausmann: review-, hausmann: commit-queue-
updated patch hausmann: review+, hausmann: commit-queue-

Description t.zander 2010-03-29 02:15:08 PDT
Created attachment 51888 [details]
patch

to make webkit compile on a linux box using gcce and cross compiling to arm for symbian I found that the attached change was required.
Comment 1 WebKit Review Bot 2010-03-29 02:20:10 PDT
Attachment 51888 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Simon Hausmann 2010-03-29 02:24:30 PDT
Comment on attachment 51888 [details]
patch

Looks okay to me in principle, but can you explain why you're excluding these two statements?

Please also add a link to the bugzilla entry in the ChangeLog?
Comment 3 t.zander 2010-03-29 02:40:05 PDT
Before the only symbian build system seeing those lines were the Windows (aka
MMP) based ones. Now the linux system sees them too. And those lines are not
valid there so they have to be excluded specifically.

Do you want me to re-submit it re-indented?
Comment 4 Simon Hausmann 2010-03-29 03:48:18 PDT
(In reply to comment #3)
> Before the only symbian build system seeing those lines were the Windows (aka
> MMP) based ones. Now the linux system sees them too. And those lines are not
> valid there so they have to be excluded specifically.
> 
> Do you want me to re-submit it re-indented?

The indentation is fine, but it would be good to have the explanation in the ChangeLog or to have a link from the ChangeLog to this bugzilla entry, so that it's possible to find out what happened when looking at the .pro file in three months :)
Comment 5 t.zander 2010-03-29 03:58:41 PDT
Created attachment 51897 [details]
updated patch
Comment 6 Simon Hausmann 2010-03-29 04:12:58 PDT
Comment on attachment 51897 [details]
updated patch

Ok! For the purpose of getting this into the release soon, I'll also land it manually.
Comment 7 Simon Hausmann 2010-03-29 04:14:59 PDT
Committed r56715: <http://trac.webkit.org/changeset/56715>
Comment 8 Simon Hausmann 2010-03-29 04:16:47 PDT
Revision r56715 cherry-picked into qtwebkit-2.0 with commit e769d1eecfec361b8b555dbdbc10a20d40e22fd9