Summary: | Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, fishd, webkit.review.bot, zmo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kenneth Russell
2010-03-28 19:34:21 PDT
Created attachment 51874 [details]
Patch
Attachment 51874 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp:31: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 51874 [details] Patch > Index: WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp > + // FIXME: add GL_BGRA extension support > + for (int i = 0; i < size; i += 4) > + std::swap(outputVector[i], outputVector[i + 2]); > + *format = RGBA; > return true; > } ^^^ it would be nice to add a comment above the loop explaining that you are converting from BGRA to RGBA. r=me with such a comment Created attachment 51928 [details]
Revised patch
Revised patch addressing review feedback and style issue.
Comment on attachment 51928 [details] Revised patch Clearing flags on attachment: 51928 Committed r56735: <http://trac.webkit.org/changeset/56735> All reviewed patches have been landed. Closing bug. |