Bug 36723

Summary: Crash while uploading a PDF document on www.largefilesasap.com
Product: WebKit Reporter: stamatgeorge
Component: New BugsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Critical CC: ap, beidson, darin, tkent
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch beidson: review+

stamatgeorge
Reported 2010-03-28 08:21:36 PDT
I tried uploading a PDF document on www.largefilesasap.com and it crashed while trying to upload the PDF document: Process: Safari [22856] Path: /Applications/Safari.app/Contents/MacOS/Safari Identifier: org.webkit.nightly.WebKit Version: r56652 (56652) Code Type: X86 (Native) Parent Process: launchd [160] Date/Time: 2010-03-28 11:18:02.358 -0400 OS Version: Mac OS X 10.6.2 (10C540) Report Version: 6 Interval Since Last Report: 416637 sec Crashes Since Last Report: -21 Per-App Interval Since Last Report: 40810 sec Per-App Crashes Since Last Report: 2 Anonymous UUID: 38988252-EFC7-422F-A9E9-C3301B00D0DD Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000014 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x007fb3b2 WebCore::FileChooser::iconLoaded(WTF::PassRefPtr<WebCore::Icon>) + 18 1 com.apple.WebKit 0x00226d0d WebChromeClient::chooseIconForFiles(WTF::Vector<WebCore::String, 0ul> const&, WTF::PassRefPtr<WebCore::FileChooser>) + 45 2 com.apple.WebCore 0x00651739 WebCore::Chrome::chooseIconForFiles(WTF::Vector<WebCore::String, 0ul> const&, WTF::PassRefPtr<WebCore::FileChooser>) + 57 3 com.apple.WebCore 0x00dd0298 WebCore::RenderFileUploadControl::chooseIconForFiles(WTF::Vector<WebCore::String, 0ul> const&) + 56 4 com.apple.WebCore 0x007fb346 WebCore::FileChooser::loadIcon() + 38 5 com.apple.WebCore 0x007fb68b WebCore::FileChooser::create(WebCore::FileChooserClient*, WTF::Vector<WebCore::String, 0ul> const&) + 91 6 com.apple.WebCore 0x00dd055c WebCore::RenderFileUploadControl::RenderFileUploadControl(WebCore::HTMLInputElement*) + 252 7 com.apple.WebCore 0x008a7fba WebCore::HTMLInputElement::createRenderer(WebCore::RenderArena*, WebCore::RenderStyle*) + 362 8 com.apple.WebCore 0x00d49ffc WebCore::Node::createRendererIfNeeded() + 188 9 com.apple.WebCore 0x007db8fd WebCore::Element::attach() + 45 10 com.apple.WebCore 0x00898be0 WebCore::HTMLFormControlElement::attach() + 32 11 com.apple.WebCore 0x008aeea6 WebCore::HTMLInputElement::attach() + 54 12 com.apple.WebCore 0x007dd9bb WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 699 13 com.apple.WebCore 0x00898a54 WebCore::HTMLFormControlElement::recalcStyle(WebCore::Node::StyleChange) + 36 14 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 15 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 16 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 17 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 18 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 19 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 20 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 21 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 22 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 23 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 24 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 25 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 26 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 27 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 28 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 29 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 30 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 31 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 32 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 33 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 34 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 35 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 36 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 37 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 38 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 39 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 40 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 41 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 42 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 43 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 44 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 45 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 46 com.apple.WebCore 0x007ddb12 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) + 1042 47 com.apple.WebCore 0x007365bf WebCore::Document::recalcStyle(WebCore::Node::StyleChange) + 191 48 com.apple.WebCore 0x00730776 WebCore::Document::updateStyleIfNeeded() + 70 49 com.apple.WebCore 0x00731e68 WebCore::Document::updateStyleForAllDocuments() + 136 50 com.apple.WebCore 0x00d4d761 WebCore::Node::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>) + 481 51 com.apple.WebCore 0x00d4dd38 WebCore::Node::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 232 52 com.apple.WebCore 0x00899199 WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent() + 137 53 com.apple.WebCore 0x00dcffb8 WebCore::RenderFileUploadControl::valueChanged() + 72 54 com.apple.WebKit 0x00228311 -[WebOpenPanelResultListener chooseFilenames:] + 257 55 com.apple.Safari 0x00120eb0 0x1000 + 1179312 56 com.apple.AppKit 0x96d2e9f6 -[NSSavePanel _didEndSheet:returnCode:contextInfo:] + 295 57 com.apple.AppKit 0x96a03081 -[NSApplication endSheet:returnCode:] + 349 58 com.apple.AppKit 0x96d27c60 -[NSSavePanel dismissWindow:] + 97 59 com.apple.AppKit 0x96d2e63c -[NSSavePanel ok:] + 260 60 com.apple.AppKit 0x96863f86 -[NSApplication sendAction:to:from:] + 112 61 com.apple.Safari 0x0004cbff 0x1000 + 310271 62 com.apple.AppKit 0x96943705 -[NSControl sendAction:to:] + 108 63 com.apple.AppKit 0x9693f1ba -[NSCell _sendActionFrom:] + 169 64 com.apple.AppKit 0x96a02b42 -[NSButtonCell performClick:] + 707 65 com.apple.AppKit 0x9695dc37 -[NSButton performKeyEquivalent:] + 378 66 com.apple.AppKit 0x9695daa7 -[NSControl _performKeyEquivalent:conditionally:] + 165 67 com.apple.AppKit 0x9695d973 -[NSView performKeyEquivalent:] + 367 68 com.apple.AppKit 0x9695d973 -[NSView performKeyEquivalent:] + 367 69 com.apple.AppKit 0x9695d973 -[NSView performKeyEquivalent:] + 367 70 com.apple.AppKit 0x9695d6e6 -[NSWindow performKeyEquivalent:] + 245 71 com.apple.AppKit 0x96d3145b -[NSSavePanel performKeyEquivalent:] + 2746 72 com.apple.AppKit 0x96a027c5 -[NSWindow keyDown:] + 93 73 com.apple.AppKit 0x96d2c962 -[NSSavePanel keyDown:] + 162 74 com.apple.AppKit 0x96850ddd forwardMethod + 113 75 com.apple.AppKit 0x96850ddd forwardMethod + 113 76 com.apple.AppKit 0x96850ddd forwardMethod + 113 77 com.apple.AppKit 0x96850ddd forwardMethod + 113 78 com.apple.AppKit 0x96850ddd forwardMethod + 113 79 com.apple.AppKit 0x96850ddd forwardMethod + 113 80 com.apple.AppKit 0x96850ddd forwardMethod + 113 81 com.apple.AppKit 0x96b4e019 -[NSControl keyDown:] + 132 82 com.apple.AppKit 0x96ac812d -[NSBrowser keyDown:] + 93 83 com.apple.AppKit 0x96850ddd forwardMethod + 113 84 com.apple.AppKit 0x96850ddd forwardMethod + 113 85 com.apple.AppKit 0x96850ddd forwardMethod + 113 86 com.apple.AppKit 0x96850ddd forwardMethod + 113 87 com.apple.AppKit 0x96850ddd forwardMethod + 113 88 com.apple.AppKit 0x96850ddd forwardMethod + 113 89 com.apple.AppKit 0x96b4e019 -[NSControl keyDown:] + 132 90 com.apple.AppKit 0x96a36ccd -[NSTableView keyDown:] + 857 91 com.apple.AppKit 0x96ac7669 -[NSBrowserTableView keyDown:] + 559 92 com.apple.AppKit 0x9693afe0 -[NSWindow sendEvent:] + 5757 93 com.apple.AppKit 0x96853b2f -[NSApplication sendEvent:] + 6431 94 com.apple.Safari 0x00031043 0x1000 + 196675 95 com.apple.AppKit 0x967e74ff -[NSApplication run] + 917 96 com.apple.AppKit 0x967df535 NSApplicationMain + 574 97 com.apple.Safari 0x00002bad 0x1000 + 7085 Thread 1: Dispatch queue: com.apple.libdispatch-manager 0 libSystem.B.dylib 0x98db30ea kevent + 10 1 libSystem.B.dylib 0x98db3804 _dispatch_mgr_invoke + 215 2 libSystem.B.dylib 0x98db2cc3 _dispatch_queue_invoke + 163 3 libSystem.B.dylib 0x98db2a68 _dispatch_worker_thread2 + 234 4 libSystem.B.dylib 0x98db24f1 _pthread_wqthread + 390 5 libSystem.B.dylib 0x98db2336 start_wqthread + 30 Thread 2: WebCore: IconDatabase 0 libSystem.B.dylib 0x98dba806 __semwait_signal + 10 1 libSystem.B.dylib 0x98dba4c2 _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x98dbc158 pthread_cond_wait$UNIX2003 + 73 3 com.apple.WebCore 0x008fa45a WebCore::IconDatabase::syncThreadMainLoop() + 266 4 com.apple.WebCore 0x008fa584 WebCore::IconDatabase::iconDatabaseSyncThread() + 180 5 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 6 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 3: Safari: SafeBrowsingManager 0 libSystem.B.dylib 0x98d8c8da mach_msg_trap + 10 1 libSystem.B.dylib 0x98d8d047 mach_msg + 68 2 com.apple.CoreFoundation 0x91c1477f __CFRunLoopRun + 2079 3 com.apple.CoreFoundation 0x91c13864 CFRunLoopRunSpecific + 452 4 com.apple.CoreFoundation 0x91c13691 CFRunLoopRunInMode + 97 5 com.apple.Safari 0x00025939 0x1000 + 149817 6 com.apple.Safari 0x000255ec 0x1000 + 148972 7 com.apple.Safari 0x00025585 0x1000 + 148869 8 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 9 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 4: 0 libSystem.B.dylib 0x98d8c8da mach_msg_trap + 10 1 libSystem.B.dylib 0x98d8d047 mach_msg + 68 2 com.apple.CoreFoundation 0x91c1477f __CFRunLoopRun + 2079 3 com.apple.CoreFoundation 0x91c13864 CFRunLoopRunSpecific + 452 4 com.apple.CoreFoundation 0x91c13691 CFRunLoopRunInMode + 97 5 com.apple.Foundation 0x90ba9430 +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] + 329 6 com.apple.Foundation 0x90b708d8 -[NSThread main] + 45 7 com.apple.Foundation 0x90b70888 __NSThread__main__ + 1499 8 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 9 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 5: Safari: SnapshotStore 0 libSystem.B.dylib 0x98dba806 __semwait_signal + 10 1 libSystem.B.dylib 0x98dba4c2 _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x98dbc158 pthread_cond_wait$UNIX2003 + 73 3 com.apple.JavaScriptCore 0x00546091 WTF::ThreadCondition::timedWait(WTF::Mutex&, double) + 81 4 com.apple.Safari 0x0004224d 0x1000 + 266829 5 com.apple.Safari 0x0004219d 0x1000 + 266653 6 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 7 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 6: 0 libSystem.B.dylib 0x98dab856 select$DARWIN_EXTSN + 10 1 com.apple.CoreFoundation 0x91c53ddd __CFSocketManager + 1085 2 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 3 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 7: 0 libSystem.B.dylib 0x98d8c8da mach_msg_trap + 10 1 libSystem.B.dylib 0x98d8d047 mach_msg + 68 2 com.apple.CoreFoundation 0x91c1477f __CFRunLoopRun + 2079 3 com.apple.CoreFoundation 0x91c13864 CFRunLoopRunSpecific + 452 4 com.apple.CoreFoundation 0x91c197a4 CFRunLoopRun + 84 5 com.apple.DesktopServices 0x9537463f TSystemNotificationTask::SystemNotificationTaskProc(void*) + 643 6 ...ple.CoreServices.CarbonCore 0x942307ae PrivateMPEntryPoint + 68 7 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 8 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 8: 0 libSystem.B.dylib 0x98db2182 __workq_kernreturn + 10 1 libSystem.B.dylib 0x98db2718 _pthread_wqthread + 941 2 libSystem.B.dylib 0x98db2336 start_wqthread + 30 Thread 9: 0 libSystem.B.dylib 0x98db2182 __workq_kernreturn + 10 1 libSystem.B.dylib 0x98db2718 _pthread_wqthread + 941 2 libSystem.B.dylib 0x98db2336 start_wqthread + 30 Thread 10: 0 libSystem.B.dylib 0x98dba806 __semwait_signal + 10 1 libSystem.B.dylib 0x98dba4c2 _pthread_cond_wait + 1191 2 libSystem.B.dylib 0x98dbc158 pthread_cond_wait$UNIX2003 + 73 3 com.apple.CoreVideo 0x97c000c8 CVDisplayLink::runIOThread() + 988 4 com.apple.CoreVideo 0x97bffcd0 startIOThread(void*) + 156 5 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 6 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 11: 0 libSystem.B.dylib 0x98dba806 __semwait_signal + 10 1 libSystem.B.dylib 0x98de6441 nanosleep$UNIX2003 + 188 2 libSystem.B.dylib 0x98de637f usleep$UNIX2003 + 61 3 com.apple.AppKit 0x9698f1ed -[NSUIHeartBeat _heartBeatThread:] + 2039 4 com.apple.Foundation 0x90b708d8 -[NSThread main] + 45 5 com.apple.Foundation 0x90b70888 __NSThread__main__ + 1499 6 libSystem.B.dylib 0x98db9fbd _pthread_start + 345 7 libSystem.B.dylib 0x98db9e42 thread_start + 34 Thread 12: 0 libSystem.B.dylib 0x98db2182 __workq_kernreturn + 10 1 libSystem.B.dylib 0x98db2718 _pthread_wqthread + 941 2 libSystem.B.dylib 0x98db2336 start_wqthread + 30 Thread 0 crashed with X86 Thread State (32-bit): eax: 0xbfffcf0c ebx: 0x00000000 ecx: 0x1a053090 edx: 0x00001000 edi: 0xbfffcfec esi: 0xbfffcf0c ebp: 0xbfffcee8 esp: 0xbfffced0 ss: 0x0000001f efl: 0x00010282 eip: 0x007fb3b2 cs: 0x00000017 ds: 0x0000001f es: 0x0000001f fs: 0x00000000 gs: 0x00000037 cr2: 0x00000014 Binary Images: 0x1000 - 0x1b5fe7 com.apple.Safari 4.0.5 (6531.22.7) <179BBADD-7C49-EF3C-BD19-E988CCD9AE10> /Applications/Safari.app/Contents/MacOS/Safari 0x209000 - 0x20bff7 +WebKitNightlyEnabler.dylib ??? (???) <A19CCE54-FEC9-A376-1A72-3738C14C1B08> /Applications/WebKit.app/Contents/Resources/WebKitNightlyEnabler.dylib 0x211000 - 0x31dfe7 com.apple.WebKit r56652 (533.3+) <0B195310-AD3F-D1F9-AA2C-C3BA578DB8AC> /Applications/WebKit.app/Contents/Frameworks/10.6/WebKit.framework/Versions/A/WebKit 0x3af000 - 0x573ffb com.apple.JavaScriptCore 533+ (533.3+) <B9897B5F-1B5F-E04D-865B-E2090F6CF316> /Applications/WebKit.app/Contents/Frameworks/10.6/JavaScriptCore.framework/Versions/A/JavaScriptCore 0x5c4000 - 0x108dfe7 com.apple.WebCore 533+ (533.3+) <33DD6153-0481-CC28-A9CD-3AD0F857FDE5> /Applications/WebKit.app/Contents/Frameworks/10.6/WebCore.framework/Versions/A/WebCore 0x15ca000 - 0x15efff7 +org.andymatuschak.Sparkle 1.5 Beta (git) (830f633) <A2AD00B0-7B4D-5B2D-284C-B7B70DF2A687> /Applications/WebKit.app/Contents/Frameworks/10.6/Sparkle.framework/Versions/A/Sparkle 0x1600000 - 0x16b5fe7 libcrypto.0.9.7.dylib ??? (???) <39CDB041-9DF5-01B1-4B33-03EC4CCA40B3> /usr/lib/libcrypto.0.9.7.dylib 0x17d4000 - 0x17d5fff +com.ecamm.pluginloader Ecamm Plugin Loader v1.0.5 (1.0.5) /Library/InputManagers/Ecamm/Ecamm Plugin Loader.bundle/Contents/MacOS/Ecamm Plugin Loader 0x180e6000 - 0x180e9ff7 +net.culater.SIMBL.osax 0.9.7 (0.9.7) <1ED9449E-F730-3315-7BE2-09DAD7462E7D> /Library/ScriptingAdditions/SIMBL.osax/Contents/MacOS/SIMBL 0x180ef000 - 0x180faff7 +com.sweetpproductions.SafariCookies 1.3.8 (1.3.8) <95F68630-11CF-237F-8390-C1AA1DBAE7A6> /Library/Application Support/SIMBL/Plugins/Safari Cookies.bundle/Contents/MacOS/Safari Cookies 0x189ae000 - 0x189b9ff7 +com.evernote.EvernoteSafariClipperPlugin 1.0 (76126) <1D595260-DFFA-646C-E359-3A51580C42FF> /Users/stamatgeorge/Library/Internet Plug-Ins/EvernoteSafariClipperPlugin.webplugin/Contents/MacOS/EvernoteSafariClipperPlugin 0x189cb000 - 0x189cbff7 com.apple.JavaPluginCocoa 13.1.0 (13.1.0) <C2C8B385-DB44-1D5E-5221-9ED1BA43930B> /System/Library/Frameworks/JavaVM.framework/Versions/A/Resources/JavaPluginCocoa.bundle/Contents/MacOS/JavaPluginCocoa 0x189d0000 - 0x189d7ff7 com.apple.JavaVM 13.1.0 (13.1.0) <2842C4EE-869D-81E6-E771-062F583A1044> /System/Library/Frameworks/JavaVM.framework/Versions/A/JavaVM 0x194e4000 - 0x194ecff7 com.apple.qldisplay.PDF 2.1 (327.3) <713971B0-2EFD-65ED-F992-0A223170BA65> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuickLookUI.framework/Versions/A/Resources/DisplayBundles/PDF.qldisplay/Contents/MacOS/PDF 0x19e8f000 - 0x19eabff7 GLRendererFloat ??? (???) <8FF7B576-512C-C2F8-4C0C-967FB3D9EEA2> /System/Library/Frameworks/OpenGL.framework/Resources/GLRendererFloat.bundle/GLRendererFloat 0x1a100000 - 0x1a271ff7 GLEngine ??? (???) <D336658A-F6DB-6D61-9CA6-04299E7D5420> /System/Library/Frameworks/OpenGL.framework/Resources/GLEngine.bundle/GLEngine 0x1bd28000 - 0x1c18ffef com.apple.driver.AppleIntelGMAX3100GLDriver 1.6.6 (6.0.6) <B6C9D049-F83A-8F22-5CF2-69B147410B02> /System/Library/Extensions/AppleIntelGMAX3100GLDriver.bundle/Contents/MacOS/AppleIntelGMAX3100GLDriver 0x8fe00000 - 0x8fe4162b dyld 132.1 (???) <211AF0DD-42D9-79C8-BB6A-1F4BEEF4B4AB> /usr/lib/dyld 0x900bf000 - 0x900c3ff7 libGIF.dylib ??? (???) <83FB0DCC-355F-A930-E570-0BD95086CC59> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0x900c4000 - 0x90160fe7 com.apple.ApplicationServices.ATS 4.1 (???) <EA26375D-8276-9671-645D-D28CAEC95292> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x90183000 - 0x90631fe7 com.apple.VideoToolbox 0.420.18 (420.18) <CB16BB7D-FBE2-A2AD-490A-18479A8321BA> /System/Library/PrivateFrameworks/VideoToolbox.framework/Versions/A/VideoToolbox 0x9065e000 - 0x906defeb com.apple.SearchKit 1.3.0 (1.3.0) <9E18AEA5-F4B4-8BE5-EEA9-818FC4F46FD9> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x907fb000 - 0x907feff7 libCGXType.A.dylib ??? (???) <483FCF1C-066B-D210-7355-ABC48CA9DB2F> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGXType.A.dylib 0x907ff000 - 0x9083eff7 com.apple.ImageCaptureCore 1.0 (1.0) <D8767350-A10D-B6B5-3A8D-05888A7758ED> /System/Library/Frameworks/ImageCaptureCore.framework/Versions/A/ImageCaptureCore 0x90890000 - 0x908ddfeb com.apple.DirectoryService.PasswordServerFramework 6.0 (6.0) <BF66BA5D-BBC8-78A5-DBE2-F9DE3DD1D775> /System/Library/PrivateFrameworks/PasswordServer.framework/Versions/A/PasswordServer 0x908f8000 - 0x909a7ff3 com.apple.ColorSync 4.6.2 (4.6.2) <F3F097AC-FDB7-3357-C64F-E28BECF4C15F> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x909a8000 - 0x90a0cffb com.apple.htmlrendering 72 (1.1.4) <4D451A35-FAB6-1288-71F6-F24A4B6E2371> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering 0x90a0d000 - 0x90a7bff7 com.apple.ISSupport 1.9.2 (50) <A9BDA884-D0AF-9F39-0840-8B7F5E8E2031> /System/Library/PrivateFrameworks/ISSupport.framework/Versions/A/ISSupport 0x90a7c000 - 0x90a86ff7 com.apple.CrashReporterSupport 10.6.2 (239) <746DBA09-A901-E5FE-8605-F5EC3D9359FF> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport 0x90a87000 - 0x90afefe3 com.apple.backup.framework 1.2 (1.2) <411D14B1-0E2D-25FF-F329-CE92C70DDEC3> /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup 0x90aff000 - 0x90b34ff7 libcups.2.dylib ??? (???) <AFDC4D3C-0FF4-D459-B26C-4BA1093F9142> /usr/lib/libcups.2.dylib 0x90b35000 - 0x90b38ffb com.apple.help 1.3.1 (41) <67F1F424-3983-7A2A-EC21-867BE838E90B> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help 0x90b39000 - 0x90b59fe7 libresolv.9.dylib ??? (???) <A48921CB-3FA7-3071-AF9C-2D86FB493A3A> /usr/lib/libresolv.9.dylib 0x90b5a000 - 0x90dcaffb com.apple.Foundation 6.6.1 (751.14) <CD815A50-BB33-5AA1-DD73-A5B07D394DDA> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x90dcb000 - 0x90e78fe7 libobjc.A.dylib ??? (???) <DF8E4CFA-3719-3415-0BF1-E8C5E561C3B1> /usr/lib/libobjc.A.dylib 0x90e79000 - 0x90eaeff7 libGLImage.dylib ??? (???) <A6007BF7-BF3C-96DC-C435-849C6B88C58A> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x90eaf000 - 0x90eb8ff7 com.apple.DiskArbitration 2.3 (2.3) <E9C40767-DA6A-6CCB-8B00-2D5706753000> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x90eb9000 - 0x90ee1ff7 libxslt.1.dylib ??? (???) <769EF4B2-C1AD-73D5-AAAD-1564DAEA77AF> /usr/lib/libxslt.1.dylib 0x90ee2000 - 0x90f04fef com.apple.DirectoryService.Framework 3.6 (621.1) <3ED4949F-9604-C109-6586-5CE5F421182B> /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService 0x90f05000 - 0x916e84b7 com.apple.CoreGraphics 1.536.12 (???) <263EB5FC-DEAD-7C5B-C486-EC86C173F952> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x916e9000 - 0x917c6ff7 com.apple.vImage 4.0 (4.0) <64597E4B-F144-DBB3-F428-0EC3D9A1219E> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x918fa000 - 0x919a2ffb com.apple.QD 3.33 (???) <196CDBA6-5B87-2767-DD57-082D71B0A5C7> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x919a3000 - 0x919b3ff7 com.apple.DSObjCWrappers.Framework 10.6 (134) <81A0B409-3906-A98F-CA9B-A49E75007495> /System/Library/PrivateFrameworks/DSObjCWrappers.framework/Versions/A/DSObjCWrappers 0x919b4000 - 0x91a0cfe7 com.apple.datadetectorscore 2.0 (80.7) <A40AA74A-9D13-2A6C-5440-B50905923251> /System/Library/PrivateFrameworks/DataDetectorsCore.framework/Versions/A/DataDetectorsCore 0x91a0d000 - 0x91a53ff7 libauto.dylib ??? (???) <85670A64-3B67-8162-D441-D8E0BE15CA94> /usr/lib/libauto.dylib 0x91a54000 - 0x91a85ff3 libTrueTypeScaler.dylib ??? (???) <6C8916A2-8F85-98E0-AAD5-0020C39C0FC9> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libTrueTypeScaler.dylib 0x91a86000 - 0x91a8bff7 com.apple.OpenDirectory 10.6 (10.6) <92582807-E8F3-3DD9-EB42-4195CFB754A1> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/OpenDirectory 0x91ad5000 - 0x91bd7fef com.apple.MeshKitIO 1.0 (49.0) <E4436373-BF5D-9644-F8B7-B72762BEC08B> /System/Library/PrivateFrameworks/MeshKit.framework/Versions/A/Frameworks/MeshKitIO.framework/Versions/A/MeshKitIO 0x91bd8000 - 0x91d4ffef com.apple.CoreFoundation 6.6.1 (550.13) <AE9FC6F7-F0B2-DE58-759E-7DB89C021A46> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x91d50000 - 0x92073fef com.apple.HIToolbox 1.6.2 (???) <E02640B9-7BC3-A4B4-6202-9E4127DDFDD6> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x920c5000 - 0x920c5ff7 com.apple.Carbon 150 (152) <608A04AB-F35D-D2EB-6629-16B88FB32074> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x920c6000 - 0x92139fff com.apple.iLifeMediaBrowser 2.1.5 (368) <30261504-7533-5424-DD15-32739DED6FB0> /System/Library/PrivateFrameworks/iLifeMediaBrowser.framework/Versions/A/iLifeMediaBrowser 0x9213a000 - 0x9256fff7 libLAPACK.dylib ??? (???) <5E2D2283-57DE-9A49-1DB0-CD027FEFA6C2> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x92570000 - 0x92576ff7 com.apple.DisplayServicesFW 2.2 (2.2) <72C790A9-F4D2-DA92-015B-4CAF478FC0C2> /System/Library/PrivateFrameworks/DisplayServices.framework/Versions/A/DisplayServices 0x92577000 - 0x925aeff7 com.apple.CoreMedia 0.420.18 (420.18) <43747711-B334-B0C7-4971-15FA586DAFBF> /System/Library/PrivateFrameworks/CoreMedia.framework/Versions/A/CoreMedia 0x925af000 - 0x925d6ff7 com.apple.quartzfilters 1.6.0 (1.6.0) <879A3B93-87A6-88FE-305D-DF1EAED04756> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzFilters.framework/Versions/A/QuartzFilters 0x925eb000 - 0x92665fef com.apple.audio.CoreAudio 3.2.2 (3.2.2) <1F97B48A-327B-89CC-7C01-3865179716E0> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x9270f000 - 0x92788ff7 com.apple.PDFKit 2.5 (2.5) <58603BDB-337F-FBE3-EB11-7C31CF261995> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/PDFKit.framework/Versions/A/PDFKit 0x92789000 - 0x92796ff7 com.apple.opengl 1.6.5 (1.6.5) <0AE8B897-8A80-2C14-D6FC-DC21AC423234> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0x92797000 - 0x9279bff7 libGFXShared.dylib ??? (???) <79F4F60E-0A6D-CE9C-282E-FA85825449E3> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGFXShared.dylib 0x9279c000 - 0x928a9ff7 com.apple.MediaToolbox 0.420.18 (420.18) <31935D52-1F8D-4AB2-CCA5-4CF615CBCE24> /System/Library/PrivateFrameworks/MediaToolbox.framework/Versions/A/MediaToolbox 0x928b2000 - 0x928b3ff7 com.apple.TrustEvaluationAgent 1.1 (1) <6C04C4C5-667E-2EBE-EB96-5B67BD4B2185> /System/Library/PrivateFrameworks/TrustEvaluationAgent.framework/Versions/A/TrustEvaluationAgent 0x928b4000 - 0x928c8fe7 libbsm.0.dylib ??? (???) <14CB053A-7C47-96DA-E415-0906BA1B78C9> /usr/lib/libbsm.0.dylib 0x93882000 - 0x938bcffb libFontRegistry.dylib ??? (???) <72342297-E8D6-B071-A752-014134129282> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontRegistry.dylib 0x938bd000 - 0x9398efe3 ColorSyncDeprecated.dylib ??? (???) <1CEB1F35-EF10-A63D-AD9E-D7BD391D4719> /System/Library/Frameworks/ApplicationServices.framework/Frameworks/ColorSync.framework/Versions/A/Resources/ColorSyncDeprecated.dylib 0x93a15000 - 0x93a20ff7 libCSync.A.dylib ??? (???) <9292E6E3-70C1-1DD7-4213-1044F0FA8381> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib 0x93a21000 - 0x93a90ff7 libvMisc.dylib ??? (???) <59243A8C-2B98-3E71-8032-884D4853E79F> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x93a91000 - 0x93a97fff com.apple.CommonPanels 1.2.4 (91) <2438AF5D-067B-B9FD-1248-2C9987F360BA> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels 0x93abf000 - 0x93b00ff7 libRIP.A.dylib ??? (???) <9F0ECE75-1F03-60E4-E29C-136A27C13F2E> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib 0x93b21000 - 0x93b2bffb com.apple.speech.recognition.framework 3.11.1 (3.11.1) <EC0E69C8-A121-70E8-43CF-E6FC4C7779EC> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x93c11000 - 0x93c53fe7 libvDSP.dylib ??? (???) <8F8FFFB3-81E3-2969-5688-D5B0979182E6> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x93c54000 - 0x93c6fff7 libPng.dylib ??? (???) <3F8682CD-C05B-607D-96E7-767646C77DB8> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x93c70000 - 0x93c80ff3 SyndicationUI ??? (???) <180B4587-8F46-2B89-B009-ABBA82397C2F> /System/Library/PrivateFrameworks/SyndicationUI.framework/Versions/A/SyndicationUI 0x93c81000 - 0x93cf1ff3 com.apple.AppleVAFramework 4.7.5 (4.7.5) <464A915D-E670-FA22-7799-454259D42B82> /System/Library/PrivateFrameworks/AppleVA.framework/Versions/A/AppleVA 0x93cf2000 - 0x93df6fe7 libcrypto.0.9.8.dylib ??? (???) <2E58547A-91CC-4C1A-9FCC-DA7515FDB68A> /usr/lib/libcrypto.0.9.8.dylib 0x93df7000 - 0x93f0dff7 com.apple.PubSub 1.0.4 (65.12.1) <1B79C698-A2A1-6B74-A137-67516ABE088E> /System/Library/Frameworks/PubSub.framework/Versions/A/PubSub 0x93f0e000 - 0x93f22ffb com.apple.speech.synthesis.framework 3.10.35 (3.10.35) <57DD5458-4F24-DA7D-0927-C3321A65D743> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x93f84000 - 0x93ff2ff7 com.apple.QuickLookUIFramework 2.1 (327.3) <2F51D9CB-F827-E0AF-F201-5F4244C0D02A> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuickLookUI.framework/Versions/A/QuickLookUI 0x9420a000 - 0x94529fe7 com.apple.CoreServices.CarbonCore 861.2 (861.2) <A9077470-3786-09F2-E0C7-F082B7F97838> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x9452a000 - 0x94620ff7 libGLProgrammability.dylib ??? (???) <82D03736-D30C-C013-BBB1-20ED9687D47F> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib 0x947ce000 - 0x9480eff3 com.apple.securityinterface 4.0.1 (37214) <BBC88C96-8827-91DC-0CF6-7CB639183395> /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface 0x9493c000 - 0x94942ff7 libCGXCoreImage.A.dylib ??? (???) <5233872A-EAC6-1D42-3959-6CE6C5DEB931> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGXCoreImage.A.dylib 0x94943000 - 0x94976ff7 com.apple.AE 496.1 (496.1) <1AC75AE2-AF94-2458-0B94-C3BB0115BA4B> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x94977000 - 0x9498cfff com.apple.ImageCapture 6.0 (6.0) <3F31833A-38A9-444E-02B7-17619CA6F2A0> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture 0x9498d000 - 0x94a1efe7 com.apple.print.framework.PrintCore 6.1 (312.3) <6D4322AF-703C-CC19-77B4-53E6D3BB18D4> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x94a1f000 - 0x94a6fff7 com.apple.framework.familycontrols 2.0 (2.0) <E6CAB425-3E40-65A3-0C23-150C26E9CBBF> /System/Library/PrivateFrameworks/FamilyControls.framework/Versions/A/FamilyControls 0x94a70000 - 0x94a7efe7 libz.1.dylib ??? (???) <7B7A02AB-DA99-6180-880E-D28E4F9AA8EB> /usr/lib/libz.1.dylib 0x94afa000 - 0x94b3dff7 com.apple.NavigationServices 3.5.3 (181) <28CDD978-030E-7D4A-5334-874A8EBE6C29> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices 0x95372000 - 0x9544cff3 com.apple.DesktopServices 1.5.3 (1.5.3) <DA02AC94-7B0C-BD75-2305-C46A307A5FB0> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x9544d000 - 0x9545aff7 libbz2.1.0.dylib ??? (???) <495732E1-2AC4-44FC-E633-4CBCC503B924> /usr/lib/libbz2.1.0.dylib 0x9545b000 - 0x954b1ff7 com.apple.MeshKitRuntime 1.0 (49.0) <BCB920E3-C567-3F37-D404-F518A256859E> /System/Library/PrivateFrameworks/MeshKit.framework/Versions/A/Frameworks/MeshKitRuntime.framework/Versions/A/MeshKitRuntime 0x954b2000 - 0x954bcfe7 com.apple.audio.SoundManager 3.9.3 (3.9.3) <5F494955-7290-2D91-DA94-44B590191771> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound 0x954bd000 - 0x954beff7 com.apple.MonitorPanelFramework 1.3.0 (1.3.0) <0EC4EEFF-477E-908E-6F21-ED2C973846A4> /System/Library/PrivateFrameworks/MonitorPanel.framework/Versions/A/MonitorPanel 0x954bf000 - 0x95519fe7 com.apple.CorePDF 1.1 (1.1) <8ED0FB5F-D498-D012-DF09-DE5378D40D52> /System/Library/PrivateFrameworks/CorePDF.framework/Versions/A/CorePDF 0x9551a000 - 0x95813fef com.apple.QuickTime 7.6.3 (1591.3) <803CC5FD-2369-83B5-795D-A8963620EFAC> /System/Library/Frameworks/QuickTime.framework/Versions/A/QuickTime 0x95841000 - 0x95841ff7 com.apple.quartzframework 1.5 (1.5) <CEB78F00-C5B2-3B3F-BF70-DD6D578719C0> /System/Library/Frameworks/Quartz.framework/Versions/A/Quartz 0x9587b000 - 0x9587bff7 com.apple.ApplicationServices 38 (38) <8012B504-3D83-BFBB-DA65-065E061CFE03> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x95ba3000 - 0x95bbbff7 com.apple.CFOpenDirectory 10.6 (10.6) <1537FB4F-C112-5D12-1E5D-3B1002A4038F> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/Frameworks/CFOpenDirectory.framework/Versions/A/CFOpenDirectory 0x95bbc000 - 0x95ceafe7 com.apple.CoreData 102.1 (250) <F33FF4A1-D7F9-4F6D-3153-E5F2588479EB> /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x95ceb000 - 0x95d9efff libFontParser.dylib ??? (???) <FAD5E96D-CF93-CC86-6B30-A6594B930772> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontParser.dylib 0x95d9f000 - 0x95da1ff7 libRadiance.dylib ??? (???) <462903E2-2E77-FAE5-4ED6-829AAB1980A4> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x95dad000 - 0x95e5bff3 com.apple.ink.framework 1.3.1 (105) <CA3FBDC3-4BBA-7BD9-0777-A7B0751292CD> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink 0x95e5c000 - 0x95f88feb com.apple.audio.toolbox.AudioToolbox 1.6.2 (1.6.2) <9AAFDCBE-C68C-3BB3-8089-83CD2C0B4ED7> /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x95f89000 - 0x95fc6ff7 com.apple.SystemConfiguration 1.10.1 (1.10.1) <BA676C76-6AAD-F630-626D-B9248535294D> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x95fc7000 - 0x95fc7ff7 com.apple.CoreServices 44 (44) <AC35D112-5FB9-9C8C-6189-5F5945072375> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x95fc8000 - 0x96081fe7 libsqlite3.dylib ??? (???) <16CEF8E8-8C9A-94CD-EF5D-05477844C005> /usr/lib/libsqlite3.dylib 0x96082000 - 0x96082ff7 com.apple.Accelerate 1.5 (Accelerate 1.5) <F642E7A0-3720-FA19-0190-E6DBD9EF2D9B> /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x96083000 - 0x960bbff7 com.apple.LDAPFramework 2.0 (120.1) <681A0B2E-BCB2-D2BA-3D02-A4989E9C7686> /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP 0x960bc000 - 0x960c6ff7 com.apple.HelpData 2.0.4 (34) <9128FFEB-0F6C-B273-FCF4-D87A20227345> /System/Library/PrivateFrameworks/HelpData.framework/Versions/A/HelpData 0x96223000 - 0x9625afe7 libssl.0.9.8.dylib ??? (???) <95FE66AC-C850-4AB4-DD3F-7F198A5E1EAC> /usr/lib/libssl.0.9.8.dylib 0x9625b000 - 0x963ddfe7 libicucore.A.dylib ??? (???) <2B0182F3-F459-B452-CC34-46FE73ADE348> /usr/lib/libicucore.A.dylib 0x9642c000 - 0x9642cff7 liblangid.dylib ??? (???) <B99607FC-5646-32C8-2C16-AFB5EA9097C2> /usr/lib/liblangid.dylib 0x9642d000 - 0x96476fe7 libTIFF.dylib ??? (???) <5864AE5B-EAEB-F8B6-18FB-3D27B7895A4C> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x96477000 - 0x9647efff com.apple.print.framework.Print 6.0 (237) <7A06B15C-B835-096E-7D96-C2FE8F0D21E1> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print 0x9647f000 - 0x9647fff7 com.apple.vecLib 3.5 (vecLib 3.5) <17BEEF92-DF30-CD52-FD65-0B7B43B93617> /System/Library/Frameworks/vecLib.framework/Versions/A/vecLib 0x96658000 - 0x96694fff com.apple.CoreMediaIOServices 124.0 (850) <5F9B1AA3-8BB3-4E8C-2A31-F8FD5EC3F28A> /System/Library/PrivateFrameworks/CoreMediaIOServices.framework/Versions/A/CoreMediaIOServices 0x967dd000 - 0x970bbff7 com.apple.AppKit 6.6.3 (1038.25) <72A9AA47-8DCB-DB07-64F5-F837E98C62D8> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x970bc000 - 0x970e2fff com.apple.DictionaryServices 1.1.1 (1.1.1) <02709230-9B37-C743-6E27-3FCFD18211F8> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices 0x970e3000 - 0x97165ffb SecurityFoundation ??? (???) <29C27E0E-B2B3-BF6B-B1F8-5783B8B01535> /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation 0x97166000 - 0x97173ff7 com.apple.NetFS 3.2.1 (3.2.1) <5E61A00B-FA16-9D99-A064-47BDC5BC9A2B> /System/Library/Frameworks/NetFS.framework/Versions/A/NetFS 0x97174000 - 0x97180ff7 libkxld.dylib ??? (???) <3D2C5BA3-6A8D-C861-B346-0E19942D9AF1> /usr/lib/system/libkxld.dylib 0x97188000 - 0x971c6ff7 com.apple.QuickLookFramework 2.1 (327.3) <BAF90576-16DF-13E6-9756-31537076E843> /System/Library/Frameworks/QuickLook.framework/Versions/A/QuickLook 0x971da000 - 0x9721efe7 com.apple.Metadata 10.6.2 (507.4) <DBCBAE7D-7B34-7806-C0B9-1E6E6D45562F> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x9721f000 - 0x9721fff7 com.apple.Cocoa 6.6 (???) <EA27B428-5904-B00B-397A-185588698BCC> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x97220000 - 0x97587ff7 com.apple.QuartzCore 1.6.1 (227.8) <8B90AB08-46A4-1C5C-4E71-C6AB652477B9> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x97588000 - 0x97652fef com.apple.CoreServices.OSServices 352 (352) <D9F21CA4-EED0-705F-8F3C-F1322D114B52> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x97653000 - 0x9767dff7 com.apple.shortcut 1.1 (1.1) <B0514FA9-7CAE-AD94-93CA-7B2A2C5F7B8A> /System/Library/PrivateFrameworks/Shortcut.framework/Versions/A/Shortcut 0x9772d000 - 0x9772dff7 com.apple.Accelerate.vecLib 3.5 (vecLib 3.5) <3E039E14-2A15-56CC-0074-EE59F9FBB913> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x9772e000 - 0x977cbfe3 com.apple.LaunchServices 362 (362) <8BE1C1A1-BF71-CE07-F3FB-6057D47AF461> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x978a8000 - 0x978c8fe7 com.apple.opencl 12 (12) <2DB56F60-577B-6724-5708-7B082F62CC0F> /System/Library/Frameworks/OpenCL.framework/Versions/A/OpenCL 0x97998000 - 0x97bfafe7 com.apple.security 6.1.1 (37594) <9AA7D9BF-852F-111F-68AD-65DD760D4DF3> /System/Library/Frameworks/Security.framework/Versions/A/Security 0x97bfe000 - 0x97c1cff7 com.apple.CoreVideo 1.6.0 (43.1) <1FB01BE0-B013-AE86-A063-481BB547D2F5> /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x97c8c000 - 0x97feafff com.apple.RawCamera.bundle 3.0.1 (523) <BB20C4C8-ACEE-7B40-C1A0-4BF4EC6B8796> /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera 0x97feb000 - 0x981cdfff com.apple.imageKit 2.0.1 (1.0) <3CD99122-4DC8-00CE-4BD7-E3E1E1C71C30> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/ImageKit.framework/Versions/A/ImageKit 0x981ce000 - 0x981d2ff7 IOSurface ??? (???) <C11D3FF3-EB51-A07D-EF24-9C2004115724> /System/Library/Frameworks/IOSurface.framework/Versions/A/IOSurface 0x981d3000 - 0x981e3ff7 libsasl2.2.dylib ??? (???) <C8744EA3-0AB7-CD03-E639-C4F2B910BE5D> /usr/lib/libsasl2.2.dylib 0x981e4000 - 0x985faff7 libBLAS.dylib ??? (???) <C4FB303A-DB4D-F9E8-181C-129585E59603> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x985fb000 - 0x98665fe7 libstdc++.6.dylib ??? (???) <411D87F4-B7E1-44EB-F201-F8B4F9227213> /usr/lib/libstdc++.6.dylib 0x9879c000 - 0x9879dff7 com.apple.audio.units.AudioUnit 1.6.2 (1.6.2) <845D5E0D-870D-B7E8-AAC5-8364AC341AA1> /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x9879e000 - 0x987e2ff3 com.apple.coreui 2 (113) <D0FA9B36-3708-D5BF-0CC3-6CC1909BC8E6> /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI 0x98827000 - 0x98839ff7 com.apple.MultitouchSupport.framework 204.9 (204.9) <B639F02B-33CC-150C-AE8C-1007EA7648F9> /System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/A/MultitouchSupport 0x9883a000 - 0x9883dff7 libCoreVMClient.dylib ??? (???) <A89D7A78-8FB0-2BDF-30DB-A35E04A6186B> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreVMClient.dylib 0x9883e000 - 0x988e5fe7 com.apple.CFNetwork 454.5 (454.5) <A7E78E62-0C59-CE57-73D2-C4E60527781C> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x988e6000 - 0x98946fe7 com.apple.CoreText 3.1.0 (???) <79FD1B5C-2F93-4C5D-B07B-4DD9088E67DE> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText 0x98947000 - 0x98997fe7 libGLU.dylib ??? (???) <659ADCA2-10EC-59BD-1B0A-4928A965F1D1> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x98998000 - 0x9899bfe7 libmathCommon.A.dylib ??? (???) <1622A54F-1A98-2CBE-B6A4-2122981A500E> /usr/lib/system/libmathCommon.A.dylib 0x9899c000 - 0x989b8fe3 com.apple.openscripting 1.3.1 (???) <DA16DE48-59F4-C94B-EBE3-7FAF772211A2> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting 0x989b9000 - 0x989caff7 com.apple.LangAnalysis 1.6.6 (1.6.6) <7A3862F7-3730-8F6E-A5DE-8E2CCEA979EF> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x989cb000 - 0x98accfe7 libxml2.2.dylib ??? (???) <B4C5CD68-405D-0F1B-59CA-5193D463D0EF> /usr/lib/libxml2.2.dylib 0x98b07000 - 0x98b11ff7 libGL.dylib ??? (???) <76A207FE-889A-CF1B-AF9A-795EEE5A463E> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x98b1f000 - 0x98b43ff7 libJPEG.dylib ??? (???) <649E1974-A527-AC0B-B3F4-B4DC30484070> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x98b44000 - 0x98bdcfe7 edu.mit.Kerberos 6.5.9 (6.5.9) <73EC847F-FF44-D542-2AD5-97F6C8D48F0B> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos 0x98bdd000 - 0x98d1cfe3 com.apple.QTKit 7.6.3 (1591.3) <18F25C19-F0B8-5907-D6D6-65EC53DF0D3B> /System/Library/Frameworks/QTKit.framework/Versions/A/QTKit 0x98d1d000 - 0x98d53fff libtidy.A.dylib ??? (???) <DDFAB560-3883-A6A2-7BDD-D91730982B48> /usr/lib/libtidy.A.dylib 0x98d8c000 - 0x98f30feb libSystem.B.dylib ??? (???) <D45B91B2-2B4C-AAC0-8096-1FC48B7E9672> /usr/lib/libSystem.B.dylib 0x98f31000 - 0x9915cff3 com.apple.QuartzComposer 4.1 (156.10) <24293329-50D7-D12F-51B3-57976A4E52B1> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzComposer.framework/Versions/A/QuartzComposer 0x9915d000 - 0x9915fff7 com.apple.securityhi 4.0 (36638) <962C66FB-5BE9-634E-0810-036CB340C059> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI 0x9917e000 - 0x9937efeb com.apple.AddressBook.framework 5.0.1 (864) <878FE5D9-6C49-000F-D5D1-DF8054BFC0F0> /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook 0x9937f000 - 0x9953bfef com.apple.ImageIO.framework 3.0.1 (3.0.1) <598CF4F9-7542-E1A7-26D2-584933497A2E> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x99555000 - 0x995a6ff7 com.apple.HIServices 1.8.0 (???) <B8EC13DB-A81A-91BF-8C82-66E840C64C91> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x995a7000 - 0x995d7ff7 com.apple.MeshKit 1.0 (49.0) <435718C1-ED40-6BCC-F0D8-67FA05CFFF1E> /System/Library/PrivateFrameworks/MeshKit.framework/Versions/A/MeshKit 0x995d8000 - 0x99632ff7 com.apple.framework.IOKit 2.0 (???) <1BE07087-27D5-0E62-F06B-007C2BED4073> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0xbb100000 - 0xbb103fe7 libLatinSuppConverter.dylib ??? (???) <59D12876-5E0C-803C-EC99-832012CF3416> /System/Library/CoreServices/Encodings/libLatinSuppConverter.dylib 0xffff0000 - 0xffff1fff libSystem.B.dylib ??? (???) <D45B91B2-2B4C-AAC0-8096-1FC48B7E9672> /usr/lib/libSystem.B.dylib Model: MacBook4,1, BootROM MB41.00C1.B00, 2 processors, Intel Core 2 Duo, 2.4 GHz, 2 GB, SMC 1.31f0 Graphics: Intel GMA X3100, GMA X3100, Built-In, 144 MB Memory Module: global_name AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x88), Broadcom BCM43xx 1.0 (5.10.91.26) Bluetooth: Version 2.2.4f3, 2 service, 1 devices, 1 incoming serial ports Network Service: AirPort, AirPort, en1 Serial ATA Device: FUJITSU MHY2250BH, 232.89 GB Parallel ATA Device: MATSHITADVD-R UJ-857E USB Device: Built-in iSight, 0x05ac (Apple Inc.), 0x8501, 0xfd400000 USB Device: Apple Internal Keyboard / Trackpad, 0x05ac (Apple Inc.), 0x0229, 0x5d200000 USB Device: IR Receiver, 0x05ac (Apple Inc.), 0x8242, 0x5d100000 USB Device: Bluetooth USB Host Controller, 0x05ac (Apple Inc.), 0x8205, 0x1a100000
Attachments
Patch (4.59 KB, patch)
2010-03-30 19:02 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2010-03-30 19:46 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (5.69 KB, patch)
2010-03-30 20:55 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2010-03-30 21:04 PDT, Kent Tamura 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
stamatgeorge
Comment 1 2010-03-28 08:22:05 PDT
Was using Safari Version 4.0.5 (6531.22.7, r56652) when it crashed
Alexey Proskuryakov
Comment 2 2010-03-30 13:48:11 PDT
http://trac.webkit.org/changeset/56439 ?
Kent Tamura
Comment 3 2010-03-30 18:09:17 PDT
*** Bug 36856 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 4 2010-03-30 18:12:46 PDT
(In reply to comment #2) > http://trac.webkit.org/changeset/56439 ? Yup. I'm working on this now, should be an easy fix (I have more analysis in the dupe if anyone is interested.)
Brady Eidson
Comment 5 2010-03-30 19:01:41 PDT
Fundamental problem is that the FileChooser might call into its client (RenderFileUploadControl ) during the constructor, but RenderFileUploadControl needs to pass the FileChooser off to *its* client (WebChromeClient), but it doesn't yet *have* the FileChooser to pass off. We'll either have to: A - Make the logic in void FileChooser::chooseFiles(const Vector<String>& filenames) kind of gross B - Make constructing a FileChooser a 2-stage operation (create followed by and init) C - Revert r56439 as its really just a code shuffle and didn't change any functionality.
Brady Eidson
Comment 6 2010-03-30 19:02:30 PDT
(In reply to comment #5) > Fundamental problem is that the FileChooser might call into its client > (RenderFileUploadControl ) during the constructor, but RenderFileUploadControl > needs to pass the FileChooser off to *its* client (WebChromeClient), but it > doesn't yet *have* the FileChooser to pass off. > > We'll either have to: > A - Make the logic in void FileChooser::chooseFiles(const Vector<String>& > filenames) kind of gross > B - Make constructing a FileChooser a 2-stage operation (create followed by and > init) > C - Revert r56439 as its really just a code shuffle and didn't change any > functionality. And quite honestly, my vote goes to C.
Kent Tamura
Comment 7 2010-03-30 19:02:47 PDT
Created attachment 52118 [details] Patch
Brady Eidson
Comment 8 2010-03-30 19:14:46 PDT
Comment on attachment 52118 [details] Patch Quite honestly, this is my least favorite of the three approaches I suggested. IMHO, 2 stage construction is not a great pattern unless there's no alternatives. I added this comment to the original bug (https://bugs.webkit.org/show_bug.cgi?id=35072): --- Since this patch: 1 - Didn't change functionality 2 - The approach was generally not liked by the reviewers. 3 - In general, round tripping between WebCore and WebKit is something we try to *reduce* ...I think it needs to be rolled out. --- Can you convince me why round tripping between WebCore and WebKit for 5+ different platforms was better than the previous solution that kept things entirely in WebCore except for the lone platform that needed the client interface? I know Darin expressed disdain for the duplication of the API call in https://bugs.webkit.org/show_bug.cgi?id=32054 because it would make the code more complicated and harder to maintain in the long run. But is the current state of things actually *better*? I think it's crazy that WebCore always calls out to the client interfaces for 5+ different platforms, and most of them call straight back into WebCore. This makes the code harder to follow and maintain, not easier.
Brady Eidson
Comment 9 2010-03-30 19:20:29 PDT
This comment reply moved from https://bugs.webkit.org/show_bug.cgi?id=35072 because it's more relevant to this discussion: (In reply to comment #17) > (In reply to comment #16) > > This patch (http://trac.webkit.org/changeset/56439) caused a major regression > > (https://bugs.webkit.org/show_bug.cgi?id=36723) > > > > Since: > > 1 - It didn't change functionality > > 2 - The approach was generally not liked. > > 3 - In general, round tripping between WebCore and WebKit is something we try > > to *reduce* > > > > ...I think it needs to be rolled out. > > Brady, I already post a fix for the regression. Please don't roll it out. > Even if we rolled it out, the problem would not be solved with platforms of > which Icon::iconForFiles() returns 0. Okay, that's true. The mere existence of the client interface means that if a platform returns 0 for Icon::iconForFiles(), we'd still have this problem. I'm still far from convinced that forcing all platforms through this client interface is the right thing to do when most only need what WebCore already knows how to do, and that same code is copied 4+ times.
Brady Eidson
Comment 10 2010-03-30 19:28:31 PDT
Comment on attachment 52118 [details] Patch Knowing that we'd have this problem whether or not we roll out http://trac.webkit.org/changeset/56439 , I'll review this patch differently. I like the layout test and I like the asserts in RenderFileUploadControl.cpp, but I'm not convinced of the change to 2 step construction for the FileChooser. There is exactly 1 user of FileChooser right now, so it's easy to get the 2 step construction right. But this pattern might be difficult to maintain going forward. I urge you to consider working out a clean way to remove loadIcon() from the constructor but *not* add the requirement to manually call loadIcon() afterwards. But, r+ anyways.
Kent Tamura
Comment 11 2010-03-30 19:39:42 PDT
Actually I don't like the 2 step construction too. I'll make another patch.
Kent Tamura
Comment 12 2010-03-30 19:46:56 PDT
Created attachment 52120 [details] Patch
Brady Eidson
Comment 13 2010-03-30 20:43:14 PDT
Comment on attachment 52120 [details] Patch Thanks for making this change. > @@ -79,13 +81,13 @@ void FileChooser::chooseFiles(const Vector<String>& filenames) > void FileChooser::loadIcon() > { > if (m_filenames.size() && m_client) > - m_client->chooseIconForFiles(m_filenames); > + m_client->chooseIconForFiles(this, m_filenames); > } > diff --git a/WebCore/rendering/RenderFileUploadControl.cpp b/WebCore/rendering/RenderFileUploadControl.cpp > index 14d126d..a66b118 100644 > --- a/WebCore/rendering/RenderFileUploadControl.cpp > +++ b/WebCore/rendering/RenderFileUploadControl.cpp > @@ -114,10 +114,10 @@ String RenderFileUploadControl::acceptTypes() > -void RenderFileUploadControl::chooseIconForFiles(const Vector<String>& filenames) > +void RenderFileUploadControl::chooseIconForFiles(PassRefPtr<FileChooser> chooser, const Vector<String>& filenames) > { > if (Chrome* chromePointer = chrome()) > - chromePointer->chooseIconForFiles(filenames, m_fileChooser); > + chromePointer->chooseIconForFiles(filenames, chooser); > } > diff --git a/WebCore/rendering/RenderFileUploadControl.h b/WebCore/rendering/RenderFileUploadControl.h > index 99dd35c..9714db1 100644 > --- a/WebCore/rendering/RenderFileUploadControl.h > +++ b/WebCore/rendering/RenderFileUploadControl.h > @@ -61,7 +61,7 @@ private: > - void chooseIconForFiles(const Vector<String>&); > + void chooseIconForFiles(PassRefPtr<FileChooser>, const Vector<String>&); PassRefPtr is wrong here. In the original bug, Darin pointed this out (https://bugs.webkit.org/show_bug.cgi?id=35072#c8) and you described why you thought this qualified (https://bugs.webkit.org/show_bug.cgi?id=35072#c12), and I think someone should've followed up on this. PassRefPtr is actually about *transferring* ownership. It's meant to be used when you're transferring from one RefPtr to another RefPtr. In that case, it zeroes out the old RefPtr without decrementing the ref count. It then assigns the raw pointer to the new RefPtr without incrementing the ref count. This allows ownership transfer without (surprisingly expensive) ref count churn. Creating this PassRefPtr from the raw pointer *always* bumps the ref count, even if the client isn't interested in hanging on to the object. Then the ~PassRefPtr decrements the ref count, even when the client never cared. That's the churn that PassRefPtr is actually designed to avoid. This case wasn't ever actually *transferring* ownership. While it's true that Chromium needs to ref the object to hang on to it, the RenderFileUploadControl doesn't actually *give up* its ref. In this regard, the PassRefPtr is wrong in all of the client methods originally implemented in each of the WebKits. This really can be a raw pointer. In the common platform (all but Chromium) that don't need a ref and that synchronously call back into WebCore, not ref'ing is correct. In the Chromium case, it has to bump the ref count anyways. I'm tempted to ask you to update all of the client methods to be raw pointers, but since this isn't really a hot code path, I won't insist. However, I will insist that this new method be a raw pointer, so we don't carry the mistake all the way to the core. :)
Kent Tamura
Comment 14 2010-03-30 20:55:53 PDT
Created attachment 52122 [details] Patch
Kent Tamura
Comment 15 2010-03-30 20:59:33 PDT
(In reply to comment #13) > PassRefPtr is wrong here. Thank you for the explanation. I agree that we don't need to use PassRefPtr for this change, and for Chrome::chooseIconForFiles() too. I'll address Chrome::chooseIconForFiles() when we have a conclusion for Icon interface change.
Brady Eidson
Comment 16 2010-03-30 21:00:03 PDT
Comment on attachment 52122 [details] Patch > - m_client->chooseIconForFiles(m_filenames); > + m_client->chooseIconForFiles(*this, m_filenames); > - virtual void chooseIconForFiles(const Vector<String>&) = 0; > + virtual void chooseIconForFiles(FileChooser&, const Vector<String>&) = 0; > virtual ~FileChooserClient(); > > -void RenderFileUploadControl::chooseIconForFiles(const Vector<String>& filenames) > +void RenderFileUploadControl::chooseIconForFiles(FileChooser& chooser, const Vector<String>& filenames) > { > if (Chrome* chromePointer = chrome()) > - chromePointer->chooseIconForFiles(filenames, m_fileChooser); > + chromePointer->chooseIconForFiles(filenames, &chooser); > - void chooseIconForFiles(const Vector<String>&); > + void chooseIconForFiles(FileChooser&, const Vector<String>&); We normally only use references for values stack values, and I'm not aware of anywhere where we use them for heap-only objects. This really can be a raw pointer: void chooseIconForFiles(FileChooser*, const Vector<String>&);
Kent Tamura
Comment 17 2010-03-30 21:04:34 PDT
Created attachment 52123 [details] Patch
Brady Eidson
Comment 18 2010-03-30 21:24:35 PDT
Comment on attachment 52123 [details] Patch > @@ -44,7 +45,7 @@ public: > virtual void repaint() = 0; > virtual bool allowsMultipleFiles() = 0; > virtual String acceptTypes() = 0; > - virtual void chooseIconForFiles(const Vector<String>&) = 0; > + virtual void chooseIconForFiles(FileChooser*, const Vector<String>&) = 0; > virtual ~FileChooserClient(); > }; > This is a better change, anyways - we like telling clients which object it is they're working on, because one object can be the client for multiple clientees. r+!
Kent Tamura
Comment 19 2010-03-30 21:36:18 PDT
Landed as r56824.
Note You need to log in before you can comment on or make changes to this bug.