| Summary: | SVG no AnimateColor for stroke or fill if they are set to none on target | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | charles.wei, robin.webkit, staikos, zimmermann | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 53228 [details]
Patch
Patch
Why is the property type String? And why are both strings empty? (In reply to comment #2) > Why is the property type String? And why are both strings empty? The property is set to "StringProperty" in SVGAnimateElement::resetToBaseValue, because there is no valid color for a none target. The check for empty is to ensure that this animate element is not indeed type String. I admit this patch looks ugly. Maybe the none target should be handled appropriately in SVGAnimateElement::resetToBaseValue. Do you have any suggestions? (In reply to comment #3) > (In reply to comment #2) > > Why is the property type String? And why are both strings empty? > > The property is set to "StringProperty" in SVGAnimateElement::resetToBaseValue, > because there is no valid color for a none target. The check for empty is to > ensure that this animate element is not indeed type String. > > I admit this patch looks ugly. Maybe the none target should be handled > appropriately in SVGAnimateElement::resetToBaseValue. Do you have any > suggestions? Yes, if the property Color is set to String in resetToBaseValue, it should be fixed there. Created attachment 53791 [details]
Updated patch
Update patch according to Dirk's advice. Many thanks to Dirk for the review.
Comment on attachment 53791 [details]
Updated patch
Great patch! r=me.
(In reply to comment #6) > (From update of attachment 53791 [details]) > Great patch! r=me. Land the patches manually soon. Comment on attachment 53791 [details] Updated patch Clearing flags on attachment: 53791 Committed r57896: <http://trac.webkit.org/changeset/57896> All reviewed patches have been landed. Closing bug. |
Created attachment 51853 [details] Test. The rect should turn from red to green smoothly during a second. If stroke is not set or 'none', the animation of stroke doesn't work. The color, defined in 'from', is used for the whole animation. The same for fill, if fill is set to 'none' on the target.