| Summary: | Web Inspector: records counter should be implemented in Timeline Panel. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | pfeldman, timothy | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ilya Tikhonovsky
2010-03-27 12:06:20 PDT
Created attachment 51835 [details]
[patch] first iteration.
has binary changes in localizedStrings.js
Created attachment 51836 [details]
Screenshot
It shouldn't be that big of font, maybe 1px smaller. Also not bold. It should have a 1px white text shadow on the bottom too. Created attachment 51839 [details]
Screenshot with changed font style
Looks good with the new style. Created attachment 51841 [details]
[patch] second iteration with changed text style
Created attachment 51944 [details]
[patch] fixed version
Extended version of patch.
1) records count is not affected by collapsed states of the records;
2) records count is affected by type filters;
3) zero size events were not visible if they were last events in Timeline - fixed;
4) zero size event was filtered if it was the only event in Timeline - fixed;
5) type filter was applied only for the top level events - fixed.
Comment on attachment 51944 [details]
[patch] fixed version
This is a git binary diff which uses delta diffs instead of literal diffs, unfortunately our scripts don't yet support delta diffs, so this will have to be either re-posted or landed by hand.
|