Bug 36700 – REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image

• Component: CSS
• Status: RESOLVED FIXED

[Jean-Luc Evrard]

Hi, in some circumstances, a frame is appearing around images in web pages created with iWeb (see URL). Safari (Mac/PC) as well as IE8 render correctly. Firefox Mac last version does not...
Curiously, the problem is only visible if the whole page is downloaded.
regards.

[Alexey Proskuryakov]

I'm confused. If Firefox is the only browser that doesn't work correctly, why are you reporting this problem against WebKit?

Or are you saying that this doesn't work in Safari when using a nightly build of WebKit? If so, could you please attach a screenshot, to make it more clear what problem you are seeing?

[Jean-Luc Evrard]

Created attachment 51838 [details]
two screenshots

Two screenshots of affected/unaffected rendering

[Jean-Luc Evrard]

Safari webkit (Mac) and Firefox are affected
Safari 4 (Mac/Win) and IE8 are unaffected

[Alexey Proskuryakov]

Thanks! Confirmed using r56587.

[Alexey Proskuryakov]

<rdar://problem/7801598>

This appears to be due to a change in shadow behavior in canvas.

Caused by <http://trac.webkit.org/changeset/56182>. Presumably by the change to serialization of the transparent color. Presumably the content expects rgba(0, 0, 0, 0).

From …Main/Scripts/iWebImage.js:

p_alphaComponent : function(color) {
    var alpha=1.0;
    if (color && color.indexOf('rgba(') != -1) {
        if (color.match(/rgba\((?:\s*\S+\s*,\s*){3}(\S+)\s*\)/)) {
            alpha=RegExp.$1;
        }
    }
    return alpha;
}

Created attachment 51843 [details]
Revert the CSSPrimitiveValue part of r56182

[Darin Adler]

Comment on attachment 51843 [details]
Revert the CSSPrimitiveValue part of r56182

r=me

Fixed in <http://trac.webkit.org/projects/webkit/changeset/56673>.

[Eric Seidel (no email)]

This appears to have turned the leopard bots red.

[Alexey Proskuryakov]

It would have been nice if there were a PASS/FAIL test for this.