Bug 3670

Summary: GW: Add remove and byteOrderMark support to KWQString for kdom
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P3    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
Adds remove() and byteOrderMark support to KWQString
darin: review-
Formatting oversights now fixed. darin: review+

Eric Seidel (no email)
Reported 2005-06-23 02:20:54 PDT
Add remove and byteOrderMark support to KWQString for kdom
Attachments
Adds remove() and byteOrderMark support to KWQString (1.16 KB, patch)
2005-06-23 02:26 PDT, Eric Seidel (no email) 		darin: review-
DetailsFormatted DiffDiff
Formatting oversights now fixed. (1.12 KB, patch)
2005-06-23 09:18 PDT, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-06-23 02:26:05 PDT
Created attachment 2574 [details] Adds remove() and byteOrderMark support to KWQString I'm not entirely sure about the byteOrderMark stuff, I'm not a unicode expert... The remove stuff should be just fine.
Eric Seidel (no email)
Comment 2 2005-06-23 02:26:46 PDT
Comment on attachment 2574 [details] Adds remove() and byteOrderMark support to KWQString Either way, this code is well tested, and seems to work fine for me ;-)
Darin Adler
Comment 3 2005-06-23 07:08:23 PDT
Comment on attachment 2574 [details] Adds remove() and byteOrderMark support to KWQString Formatting is incorrect in the definitions of "remove". There are extra spaces before the "(" and ")" characters. Also, there's no need for "this->" in the implenetations of those methods.
Eric Seidel (no email)
Comment 4 2005-06-23 09:18:50 PDT
Created attachment 2588 [details] Formatting oversights now fixed.
Darin Adler
Comment 5 2005-06-23 09:59:54 PDT
Comment on attachment 2588 [details] Formatting oversights now fixed. r=me
Joost de Valk (AlthA)
Comment 6 2005-07-03 08:17:36 PDT
Eric, could you confirm this one (too :) )?
Note You need to log in before you can comment on or make changes to this bug.