Bug 36693 – [Qt] Baseline accessibility support for QtWebKit

• Component: Accessibility
• Status: RESOLVED DUPLICATE

[Laszlo Gombos]

QtWebKit does not provide an implementation for AccessibilityObjectWrapper.

[Laszlo Gombos]

Created attachment 51808 [details]
proposed patch

[WebKit Review Bot]

Attachment 51808 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/accessibility/qt/AccessibilityObjectWrapperQt.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Laszlo Gombos]

Created attachment 51813 [details]
previous patch + fix style

[Simon Hausmann]

Comment on attachment 51813 [details]
previous patch + fix style

> @@ -566,6 +568,8 @@ protected:
>      AtkObject* m_wrapper;
>  #elif PLATFORM(CHROMIUM)
>      RefPtr<AccessibilityObjectWrapper> m_wrapper;
> +#elif PLATFORM(QT)
> +    RefPtr<AccessibilityObjectWrapper> m_wrapper;
>  #endif

Why not reuse the chromium preprocessor branch? :)


> Index: WebCore/accessibility/qt/AccessibilityObjectQt.cpp
> ===================================================================
> --- WebCore/accessibility/qt/AccessibilityObjectQt.cpp	(revision 56652)
> +++ WebCore/accessibility/qt/AccessibilityObjectQt.cpp	(working copy)
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright (C) 2008 Apple Ltd.
> + * Copyright (C) 2010 Nokia Inc. All rights reserved.
>   *
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Library General Public

It seems odd to me to add a copyright clase without adding any content that _is_ copyrightable.

> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp	(revision 56652)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp	(working copy)
> @@ -28,6 +28,8 @@
>  
>  #include <JavaScriptCore/JSRetainPtr.h>
>  
> +#include <limits.h>
> +
>  // Static Functions
>  

Why is this inclusion needed?


> -HEADERS = $$BASEDIR/WorkQueue.h \
> +HEADERS = \
> +    $$BASEDIR/AccessibilityController.h \
> +    $$BASEDIR/AccessibilityUIElement.h \
> +    $$BASEDIR/WorkQueue.h \
>      DumpRenderTreeQt.h \
>      EventSenderQt.h \
>      TextInputControllerQt.h \
> @@ -29,8 +32,14 @@ HEADERS = $$BASEDIR/WorkQueue.h \
>      LayoutTestControllerQt.h \
>      GCControllerQt.h \
>      testplugin.h
> -SOURCES = ../../../JavaScriptCore/wtf/Assertions.cpp \
> +
> +SOURCES = \
> +    ../../../JavaScriptCore/wtf/Assertions.cpp \
> +    $$BASEDIR/AccessibilityController.cpp \
> +    $$BASEDIR/AccessibilityUIElement.cpp \
>      $$BASEDIR/WorkQueue.cpp \
> +    AccessibilityControllerQt.cpp \
> +    AccessibilityUIElementQt.cpp \

I doubt that this approach is going to work at all at this point, as the newly added files require the JSC C API to actually work in the DRT. However there is no JSContextRef available within the Qt DRT.

[Kenneth Rohde Christiansen]

Why all those FIXME's ? why not use notImplemented() ?

[Laszlo Gombos]

*** This bug has been marked as a duplicate of bug 77864 ***