Bug 36648 – [WML] WML enabled build failure.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Nayan]

WML enabled builds are failing with following errors,

DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::optionConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’:
DerivedSources/WMLElementFactory.cpp:154: error: cannot allocate an object of abstract type ‘WebCore::WMLOptionElement’
./WebCore/wml/WMLOptionElement.h:31: note:   because the following virtual functions are pure within ‘WebCore::WMLOptionElement’:
./WebCore/dom/OptionElement.h:37: note: 	virtual bool WebCore::OptionElement::disabled() const
DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::selectConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’:
DerivedSources/WMLElementFactory.cpp:179: error: cannot allocate an object of abstract type ‘WebCore::WMLSelectElement’
./WebCore/wml/WMLSelectElement.h:30: note:   because the following virtual functions are pure within ‘WebCore::WMLSelectElement’:
./WebCore/dom/SelectElement.h:64: note: 	virtual void WebCore::SelectElement::listBoxSelectItem(int, bool, bool, bool)
make[1]: *** [DerivedSources/libwebkit_1_0_la-WMLElementFactory.lo] Error 1

[Nayan]

This build failures are due to the following changesets,

http://trac.webkit.org/changeset/56041
http://trac.webkit.org/changeset/56180

These changesets make OptionElement::disabled() and SelectElement::listBoxSelectItem pure virtual. But, WMLOptionElement and WMLSelectElement derived from these classes doesn't contain the implementation for these pure virtual function, hence resulting in build failure.

[Nayan]

Created attachment 51720 [details]
Build failure fix

[Eric Seidel (no email)]

Comment on attachment 51720 [details]
Build failure fix

Our preferred style is to always mark virtual methods as virtual.  Thus listBoxSelectItem should have virtual in its declaration.

[Nayan]

Created attachment 51821 [details]
Patch with review comments incorporated.

[Eric Seidel (no email)]

Comment on attachment 51821 [details]
Patch with review comments incorporated.

OK.  It seems these could have just as well been in the header, but OK.

[WebKit Commit Bot]

Comment on attachment 51821 [details]
Patch with review comments incorporated.

Rejecting patch 51821 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12613 test cases.
fast/canvas/webgl/index-validation.html -> failed

Exiting early after 1 failures. 5081 tests run.
88.21s total testing time

5080 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1607151

[Eric Seidel (no email)]

Comment on attachment 51821 [details]
Patch with review comments incorporated.

Flaky test.

[WebKit Commit Bot]

Comment on attachment 51821 [details]
Patch with review comments incorporated.

Clearing flags on attachment: 51821

Committed r57038: <http://trac.webkit.org/changeset/57038>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/57039 might have broken Leopard Intel Debug (Tests)

[Gyuyoung Kim]

There are build breaks as below because of duplicate patches.
Even though the patch of bug below already was puahed to trunk, this patch was landed again.

There are build breaks when wml is enabled.
(https://bugs.webkit.org/show_bug.cgi?id=36698).

-----------------------------------------------------------------------------
In file included from WebCore/dom/OptionElement.cpp:34:
./WebCore/wml/WMLOptionElement.h:59: error: ‘virtual bool WebCore::WMLOptionElement::disabled() const’ cannot be overloaded
./WebCore/wml/WMLOptionElement.h:44: error: with ‘virtual bool WebCore::WMLOptionElement::disabled() const’

In file included from WebCore/dom/SelectElement.cpp:48:
./WebCore/wml/WMLSelectElement.h:92: error: ‘virtual void WebCore::WMLSelectElement::listBoxSelectItem(int, bool, bool, bool)’ cannot be overloaded
./WebCore/wml/WMLSelectElement.h:90: error: with ‘virtual void WebCore::WMLSelectElement::listBoxSelectItem(int, bool, bool, bool)’
  CXX    WebCore/dom/libwebkit_1_0_la-SelectorNodeList.lo
make[1]: *** [WebCore/dom/libwebkit_1_0_la-SelectElement.lo] 
--------------------------------------------------------------------------------

It seems to me that one of patches should be removed.