Bug 36642

Summary: fast/replaced/border-radius-clip.html failed on Snow Leopard Debug bot
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, eric.carlson, hyatt, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 29824    
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-03-26 00:26:01 PDT
fast/replaced/border-radius-clip.html failed on Snow Leopard Debug bot

I believe this is failing intermittently.  Here is one failure:
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r56605%20(5249)/fast/replaced/border-radius-clip-diffs.txt
--- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/layout-test-results/fast/replaced/border-radius-clip-expected.txt	2010-03-25 23:43:57.000000000 -0700
+++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/layout-test-results/fast/replaced/border-radius-clip-actual.txt	2010-03-25 23:43:57.000000000 -0700
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x952
+layer at (0,0) size 785x902
   RenderView at (0,0) size 785x600
-layer at (0,0) size 785x952
-  RenderBlock {HTML} at (0,0) size 785x928
-    RenderBody {BODY} at (8,8) size 769x912
+layer at (0,0) size 785x902
+  RenderBlock {HTML} at (0,0) size 785x878
+    RenderBody {BODY} at (8,8) size 769x862
       RenderText {#text} at (0,0) size 457x18
         text run at (0,0) width 457: "All of the replaced elements below should be clipped to a border-radius. "
       RenderBR {BR} at (0,0) size 0x0
@@ -24,11 +24,11 @@
       RenderText {#text} at (304,366) size 4x18
         text run at (304,366) width 4: " "
       RenderBR {BR} at (0,0) size 0x0
-      RenderText {#text} at (300,520) size 4x18
-        text run at (300,520) width 4: " "
+      RenderText {#text} at (100,470) size 4x18
+        text run at (100,470) width 4: " "
       RenderBR {BR} at (0,0) size 0x0
-      RenderEmbeddedObject {EMBED} at (0,538) size 556x406 [bgcolor=#00FF00] [border: (3px solid #000000)]
+      RenderEmbeddedObject {EMBED} at (0,488) size 556x406 [bgcolor=#00FF00] [border: (3px solid #000000)]
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
-layer at (8,392) size 300x150
-  RenderVideo {VIDEO} at (0,384) size 300x150
+layer at (8,392) size 100x100
+  RenderVideo {VIDEO} at (0,384) size 100x100

This may be related to bug 29824.
Comment 1 Eric Seidel (no email) 2010-03-26 00:26:51 PDT
http://trac.webkit.org/browser/trunk/LayoutTests/fast/replaced/border-radius-clip.html was added 12 months ago by Hyatt.
Comment 3 Eric Seidel (no email) 2010-03-26 09:49:05 PDT
Failed again:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r56629%20(7265)/fast/replaced/border-radius-clip-diffs.txt

This seems to be a pretty common flaky test.

Is the video dynamically sized and failing to load?
Comment 4 Eric Seidel (no email) 2010-03-26 09:52:25 PDT
@eric:  Looks like the <video> tag has completed the load.  It looks like commonly it does not complete the load on time and thus does not resize itself.

The resource in question:
http://trac.webkit.org/browser/trunk/LayoutTests/fast/replaced/resources/sample.gif

Does that sound right to anyone else?
Comment 7 Eric Seidel (no email) 2010-03-30 10:39:47 PDT
Failed again on the commit bot just now.  I recommend skipping this test.
Comment 8 Eric Seidel (no email) 2010-03-30 10:44:49 PDT
Created attachment 52053 [details]
Patch
Comment 9 Adam Barth 2010-03-31 22:54:55 PDT
Comment on attachment 52053 [details]
Patch

ok.  We need a better way to track these tests.
Comment 10 Eric Seidel (no email) 2010-03-31 23:09:13 PDT
Agreed.  When the new-run-webkit-tests messiah comes at least we'll have a way to mark tests as flaky in the expectations instead of having to just skip them.
Comment 11 WebKit Commit Bot 2010-03-31 23:23:30 PDT
Comment on attachment 52053 [details]
Patch

Clearing flags on attachment: 52053

Committed r56898: <http://trac.webkit.org/changeset/56898>
Comment 12 WebKit Commit Bot 2010-03-31 23:23:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Simon Fraser (smfr) 2012-09-19 13:15:27 PDT
Test uses Flash. Bad test.
Comment 14 Ryosuke Niwa 2013-05-22 16:18:19 PDT
Turns out that this test is still flaky :(