Summary: | [Web Inspector] Allow running tests with enabled developer extras and closed Web Inspector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||
Component: | Tools / Tests | Assignee: | Yury Semikhatsky <yurys> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, ossy, pfeldman, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Yury Semikhatsky
2010-03-25 10:13:53 PDT
(In reply to comment #0) > All current inspector layout tests have Web Inspector opened before the test > page starts loading. Also "developer extras" feature state is tightly coupled > with Web Inspector window state and it's impossible to have InspectorController > enabled but Web Inspector closed. However, there is number of cases where > inspector behavior depends on whether Web Inspector is open after the inspected > page has done something or it is already open by the time the page starts to > load. Would be nice to have tests where developer exrtas are on but Web > Inspector could be open by the test when it's appropriate. Created attachment 51660 [details]
patch
Attachment 51660 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1367002 Comment on attachment 51660 [details] patch > - g_object_set(webSettings, "enable-developer-extras", TRUE, NULL); There is a tear down for other functions even though there is a reset before the subsequent test. Created attachment 51670 [details]
patch
Fixed Qt build.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/LayoutTestController.h M WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp M WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp M WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm M WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm M WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp M WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp M WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h M WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp M WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp Committed r56566 |