Bug 36610

Summary: [Web Inspector] Allow running tests with enabled developer extras and closed Web Inspector
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Tools / TestsAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, ossy, pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
pfeldman: review+
patch none

Description Yury Semikhatsky 2010-03-25 10:13:53 PDT
All current inspector layout tests have Web Inspector opened before the test page starts loading. Also "developer extras" feature state is tightly coupled with Web Inspector window state and it's impossible to have InspectorController enabled but Web Inspector closed. However, there is number of cases where inspector behavior depends on whether Web Inspector is open after the inspected page has done something or it is already open by the time the page starts to load. Would be nice to have tests where developer exrtas are on but Web Inspector could be open by the test when it's appropriate.
Comment 1 Yury Semikhatsky 2010-03-25 10:43:04 PDT
(In reply to comment #0)
> All current inspector layout tests have Web Inspector opened before the test
> page starts loading. Also "developer extras" feature state is tightly coupled
> with Web Inspector window state and it's impossible to have InspectorController
> enabled but Web Inspector closed. However, there is number of cases where
> inspector behavior depends on whether Web Inspector is open after the inspected
> page has done something or it is already open by the time the page starts to
> load. Would be nice to have tests where developer exrtas are on but Web
> Inspector could be open by the test when it's appropriate.
Comment 2 Yury Semikhatsky 2010-03-25 11:06:46 PDT
Created attachment 51660 [details]
patch
Comment 3 Csaba Osztrogon√°c 2010-03-25 11:12:56 PDT
Attachment 51660 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1367002
Comment 4 Pavel Feldman 2010-03-25 11:17:51 PDT
Comment on attachment 51660 [details]
patch

> -    g_object_set(webSettings, "enable-developer-extras", TRUE, NULL);

There is a tear down for other functions even though there is a reset before the subsequent test.
Comment 5 Yury Semikhatsky 2010-03-25 12:27:25 PDT
Created attachment 51670 [details]
patch

Fixed Qt build.
Comment 6 Yury Semikhatsky 2010-03-25 13:21:27 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/LayoutTestController.h
	M	WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
	M	WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
	M	WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm
	M	WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
	M	WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
	M	WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
	M	WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h
	M	WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
	M	WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
Committed r56566