| Summary: | [Qt] GraphicsLayer: Timing functions don't work with transitions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kim Grönholm <kim.1.gronholm> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | CLOSED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, hausmann, noam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 35784 | ||||||||
| Attachments: |
|
||||||||
Created attachment 51621 [details]
Fixes the timing functions in transform transitions with AC
If the animation value doesn't have timing function set, we need to use the animation's timing function.
Fixed also a bug in passing the duration to solveCubicBezierFunction. The duration was divided two times by 1000 and meanwhile casted to int. It needs to be kept as double and divided by 1000 only once.
LGTM :) Comment on attachment 51621 [details]
Fixes the timing functions in transform transitions with AC
Can't we make an automated test for this? Otherwise this change looks fine.
We actually can't automate the testing until QGraphicsWebView is part of our automated test process. For now we have to work on that alongside fixing AC bugs the "un-automated" way. (In reply to comment #4) > We actually can't automate the testing until QGraphicsWebView is part of our > automated test process. For now we have to work on that alongside fixing AC > bugs the "un-automated" way. ... or changing DRT before continuing with this. Comment on attachment 51621 [details] Fixes the timing functions in transform transitions with AC Clearing flags on attachment: 51621 Committed r56685: <http://trac.webkit.org/changeset/56685> All reviewed patches have been landed. Closing bug. |
Created attachment 51619 [details] Test case for transform transition timing functions. When AC is enabled, setting the -webkit-transition-timing-function for transform transition has no effect. The default timing function is always used. See the test case.