Bug 36576 – The function "roundf" included in math.h on solaris

• Component: Platform
• Status: RESOLVED INVALID

[Simon]

Created attachment 51590 [details]
The function "roundf" included in math.h on solaris

"./WebCore/platform/graphics/FloatSize.h", line 134: Error: The function "roundf" must have a prototype.
"./WebCore/platform/graphics/FloatSize.h", line 134: Error: The function "roundf" must have a prototype.
"./WebCore/platform/graphics/FloatPoint.h", line 155: Error: The function "roundf" must have a prototype.
"./WebCore/platform/graphics/FloatPoint.h", line 155: Error: The function "roundf" must have a prototype.
4 Error(s) detected.

[Eric Seidel (no email)]

Comment on attachment 51590 [details]
The function "roundf" included in math.h on solaris

Every change requires a ChangeLog.  See http://webkit.org/coding/contributing.html.

I'm not sure if MathExtras.h is supposed to include math.h or not.

[Xavier Roche]

Also required for GCC. Hence I would suggest:

--- src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h.orig    Wed Sep 14 13:22:06 2011
+++ src/3rdparty/webkit/JavaScriptCore/wtf/MathExtras.h Wed Sep 14 11:58:35 2011
@@ -190,7 +190,7 @@
 inline float rad2grad(float r) { return r * 200.0f / piFloat; }
 inline float grad2rad(float g) { return g * piFloat / 200.0f; }

-#if !COMPILER(MSVC) && !OS(ANDROID) && !OS(SYMBIAN)
+#if !COMPILER(MSVC) && !OS(ANDROID) && !OS(SYMBIAN) && !OS(SOLARIS)
 using std::isfinite;
 using std::isinf;
 using std::isnan;

[Ahmad Saleem]

Do we have Solaris port? Or we can close this unless if this is extended to any other linux port?

[Alexey Proskuryakov]

OS(SOLARIS) is gone, and in any case, I'd expect this to have been fixed since 2010 if it was still needed.