Bug 36574 – Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation

• Component: WebGL
• Status: RESOLVED FIXED

[Kenneth Russell]

The JSC and V8 custom bindings produce different failure modes when uniformMatrix4fv (and, likely, other uniform calls) are made with a null WebGLUniformLocation. V8 synthesizes a DOM SYNTAX_ERR. JSC allows the null value to go through to the WebGLRenderingContext, which synthesizes an INVALID_VALUE OpenGL error. The latter behavior is desired, and the V8 custom bindings should be changed to match it.

[Kenneth Russell]

Created attachment 52462 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 52462 [details]
Patch

> Index: WebCore/html/canvas/WebGLRenderingContext.cpp

> +    if (!location) {
> +        m_context->synthesizeGLError(GraphicsContext3D::INVALID_VALUE);
> +        return;
> +    }
> +
> +    if (location->program() != m_currentProgram) {
>          m_context->synthesizeGLError(GraphicsContext3D::INVALID_OPERATION);
>          return;
>      }

R=me, but perhaps we should have a helper method for this replicated code.

[WebKit Commit Bot]

Comment on attachment 52462 [details]
Patch

Rejecting patch 52462 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12621 test cases.
transitions/transition-end-event-transform.html -> failed

Exiting early after 1 failures. 11643 tests run.
287.40s total testing time

11642 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
10 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1653117

[Adam Barth]

Comment on attachment 52462 [details]
Patch

Let's try again.

[WebKit Commit Bot]

Comment on attachment 52462 [details]
Patch

Clearing flags on attachment: 52462

Committed r57049: <http://trac.webkit.org/changeset/57049>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.