Summary: | Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, fishd, oliver, zmo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kenneth Russell
2010-03-24 20:17:45 PDT
Created attachment 52462 [details]
Patch
Comment on attachment 52462 [details] Patch > Index: WebCore/html/canvas/WebGLRenderingContext.cpp > + if (!location) { > + m_context->synthesizeGLError(GraphicsContext3D::INVALID_VALUE); > + return; > + } > + > + if (location->program() != m_currentProgram) { > m_context->synthesizeGLError(GraphicsContext3D::INVALID_OPERATION); > return; > } R=me, but perhaps we should have a helper method for this replicated code. Comment on attachment 52462 [details] Patch Rejecting patch 52462 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12621 test cases. transitions/transition-end-event-transform.html -> failed Exiting early after 1 failures. 11643 tests run. 287.40s total testing time 11642 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1653117 Comment on attachment 52462 [details]
Patch
Let's try again.
Comment on attachment 52462 [details] Patch Clearing flags on attachment: 52462 Committed r57049: <http://trac.webkit.org/changeset/57049> All reviewed patches have been landed. Closing bug. |