Bug 36569

Summary: SQLStatementErrorCallback's return value needs to be converted to a boolean
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: CLOSED FIXED    
Severity: Normal CC: dglazkov, hausmann, michaeln, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
dumi: commit-queue-
dumi: commit-queue-
patch dglazkov: review+, dumi: commit-queue-

Description Dumitru Daniliuc 2010-03-24 18:12:57 PDT
Basically, we need to revert http://trac.webkit.org/changeset/54981. I have just talked to Hixie again, and he agreed that we should convert SQLStatementErrorCallback's return value to a boolean, instead of treating false as false, and everything else as true. This means that values such as undefined (no return value), or 0, or "false" will all be treated as false, as a Javascript developer might expect.
Comment 1 Dumitru Daniliuc 2010-03-24 18:59:26 PDT
Created attachment 51578 [details]
Comment 2 WebKit Review Bot 2010-03-24 19:06:21 PDT
Attachment 51578 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1183025
Comment 3 Dumitru Daniliuc 2010-03-24 20:36:24 PDT
Created attachment 51587 [details]

Should fix the Chromium build problems.
Comment 4 Dumitru Daniliuc 2010-03-25 12:55:18 PDT
Created attachment 51672 [details]

Same patch, without style errors this time, hopefully.
Comment 5 Dimitri Glazkov (Google) 2010-03-25 13:59:20 PDT
Comment on attachment 51672 [details]

Comment 6 Dumitru Daniliuc 2010-03-25 15:30:15 PDT
Landed as r56572.
Comment 7 Simon Hausmann 2010-06-13 14:06:43 PDT
Revision r56572 cherry-picked into qtwebkit-2.0 with commit 9917209df84aa5a739d112570394d9f57e99689b