Bug 36561

Summary:

[Qt] Make QWebPage not depend on view() but use the client->ownerWidget() instead

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

New Bugs

Assignee:

Kenneth Rohde Christiansen <kenneth>

Status:

CLOSED FIXED

Severity:

Normal

CC:

commit-queue, hausmann, tonikitoo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

35784

Attachments:

Description	Flags
Patch	none

Description Kenneth Rohde Christiansen 2010-03-24 15:16:30 PDT

Created attachment 51558 [details]
Patch

Make QWebPage not depend on view() but use the client->ownerWidget() instead. Also, handle the case where there is not page client.

Comment 1 Antonio Gomes 2010-03-24 15:37:49 PDT

style nit:

+    QStyle *style = d->client ? d->client->style() : qApp->style();

Comment 2 Eric Seidel (no email) 2010-03-25 00:47:54 PDT

Comment on attachment 51558 [details]
Patch

OK.

Comment 3 WebKit Commit Bot 2010-03-25 04:23:31 PDT

Comment on attachment 51558 [details]
Patch

Clearing flags on attachment: 51558

Committed r56529: <http://trac.webkit.org/changeset/56529>

Comment 4 WebKit Commit Bot 2010-03-25 04:23:36 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Simon Hausmann 2010-03-26 08:34:24 PDT

Revision r56529 cherry-picked into qtwebkit-2.0 with commit af7794bb8c23783a5a1dd5e5aadab33125fe543b