Summary: | [Qt] Compilation error on Qt for Embedded Linux built with -qconfig small | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tasuku Suzuki <tasuku.suzuki> | ||||||||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | CLOSED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, commit-queue, hausmann | ||||||||||||||
Priority: | P2 | Keywords: | Qt | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Other | ||||||||||||||||
OS: | Linux | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 35784 | ||||||||||||||||
Attachments: |
|
Description
Tasuku Suzuki
2010-03-24 08:18:02 PDT
Created attachment 51499 [details]
add #ifndef QT_NO_LIBRARY ~ #endif
Created attachment 51501 [details]
add #ifndef QT_NO_IM ~ #endif
Created attachment 51504 [details]
add #ifndef QT_NO_SETTINGS ~ #endif
Created attachment 51509 [details]
add #ifndef QT_NO_DEBUG_STREAM ~ #endif
Created attachment 51511 [details]
add #ifndef QT_NO_DESKTOPSERVICES ~ #endif
Comment on attachment 51501 [details]
add #ifndef QT_NO_IM ~ #endif
What does this do, and why is it useful? What does NO_IM mean?
Comment on attachment 51504 [details]
add #ifndef QT_NO_SETTINGS ~ #endif
This seems specific to inspector settings. Why woudl it be called NO_SETTINGS? I expected this to deal with Settings.h Please explain what you're tryign to do in the ChangeLog.
Comment on attachment 51509 [details]
add #ifndef QT_NO_DEBUG_STREAM ~ #endif
OK.
Comment on attachment 51511 [details]
add #ifndef QT_NO_DESKTOPSERVICES ~ #endif
OK.
Comment on attachment 51499 [details]
add #ifndef QT_NO_LIBRARY ~ #endif
Seems sane. ChangeLog could be better.
Comment on attachment 51499 [details] add #ifndef QT_NO_LIBRARY ~ #endif Clearing flags on attachment: 51499 Committed r56525: <http://trac.webkit.org/changeset/56525> Comment on attachment 51509 [details] add #ifndef QT_NO_DEBUG_STREAM ~ #endif Clearing flags on attachment: 51509 Committed r56533: <http://trac.webkit.org/changeset/56533> (In reply to comment #6) > (From update of attachment 51501 [details]) > What does this do, and why is it useful? What does NO_IM mean? QT_NO_IM disables QInputContext that abstracts the input method dependent data and composing state. The patch adds an ifdef to check QInputContext's availability. Comment on attachment 51511 [details] add #ifndef QT_NO_DESKTOPSERVICES ~ #endif Clearing flags on attachment: 51511 Committed r56536: <http://trac.webkit.org/changeset/56536> All reviewed patches have been landed. Closing bug. Created attachment 51647 [details] add #ifndef QT_NO_SETTINGS ~ #endif > This seems specific to inspector settings. Why woudl it be called NO_SETTINGS? > I expected this to deal with Settings.h Please explain what you're tryign to > do in the ChangeLog. We need to check if QSettings is available with the macro QT_NO_SETTINGS. If QSettings is disabled by Qt, inspector should not get/set settings. This is not resolved yet. Comment on attachment 51647 [details]
add #ifndef QT_NO_SETTINGS ~ #endif
This seems sad. This will spew a bunch of warnings. But OK.
Comment on attachment 51647 [details] add #ifndef QT_NO_SETTINGS ~ #endif Rejecting patch 51647 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--build-style=both', '--quiet', '51647', '--parent-command=commit-queue', '--no-update']" exit_code: 1 ERROR: Builders ["Leopard Intel Release (Tests)"] are red, please do not commit. See http://build.webkit.org. Pass --ignore-builders to bypass this check. Comment on attachment 51647 [details]
add #ifndef QT_NO_SETTINGS ~ #endif
That's our bug, not yours.
> That's our bug, not yours. https://bugs.webkit.org/show_bug.cgi?id=37009 in fact. Comment on attachment 51647 [details] add #ifndef QT_NO_SETTINGS ~ #endif Clearing flags on attachment: 51647 Committed r56984: <http://trac.webkit.org/changeset/56984> All reviewed patches have been landed. Closing bug. Re-opening becaues of missing QT_NO_IM patch. Comment on attachment 51504 [details]
add #ifndef QT_NO_SETTINGS ~ #endif
This patch is correct, it's the correct feature define in Qt for the QSettings class.
(In reply to comment #25) > (From update of attachment 51504 [details]) > This patch is correct, it's the correct feature define in Qt for the QSettings > class. An alternative patch has been merged here https://bugs.webkit.org/show_bug.cgi?id=36533#c22 see also https://bugs.webkit.org/show_bug.cgi?id=36533#c7 https://bugs.webkit.org/show_bug.cgi?id=36533#c16 Comment on attachment 51501 [details] add #ifndef QT_NO_IM ~ #endif Clearing flags on attachment: 51501 Committed r57397: <http://trac.webkit.org/changeset/57397> All reviewed patches have been landed. Closing bug. Revision r56525 cherry-picked into qtwebkit-2.0 with commit c59c560624f3fad76ff71ea1b1022543397a779e Revision r56533 cherry-picked into qtwebkit-2.0 with commit 7e5b806e5d6b024c4faf3f604c41b7d2f952c37d Revision r56536 cherry-picked into qtwebkit-2.0 with commit 74e3c511cdf041acdcdec3d34e1fa39f1595d043 Revision r56984 cherry-picked into qtwebkit-2.0 with commit 2adfb941d211c17eab2f06ac91d0c83c51576537 Revision r57397 cherry-picked into qtwebkit-2.0 with commit 6493fd316cbe4aed752ea3541affbb6f10a0aeb0 |